Onpremise: Reference to realpath in install script breaks macOS compatibility

[10xjs]

Version Information

Version: 2.3.1

Steps to Reproduce

1. run ./install.sh on macOS (11.2.3)

Expected Result

Install script runs successfully.

Actual Result

Install script immediately fails.

Logs

What you saw along the way, e.g.:

• ./install/_lib.sh: line 15: realpath: command not found

[10xjs]

This has already been (unsuccessfully) reported in https://github.com/getsentry/onpremise/issues/932 and https://github.com/getsentry/onpremise/issues/933.

[10xjs]

@misswyy I'm able to work around this issue with git checkout 2.3.1 if you are still looking for a solution.

[BYK]

Hi @10xjs, thanks for the report! We expect folks to use this repo on Linux machines so that's what we test this on. That said we like keeping it compatible with MacOS so I'll see what we can do here.

[chadwhitacre]

Blerp. Workaround is brew install coreutils until we get a fix in. Sorry!

[kmturley]

Same issue, fixed by running brew install coreutils

but then hit another error:

▶ Parsing command line ...

▶ Setting up error handling ...

▶ Checking minimum requirements ...
An error occurred, caught SIGERR on line 12

Fixed this error by running Docker process first.

It's odd that parts of the build are outside Docker, isn't the point of Docker to have a cross-platform development environment?

docker-compose up can spin up multiple containers, running installation scripts inside the containers themselves?

[chadwhitacre]

running installation scripts inside the containers themselves

Not a bad idea, though this would be a pretty significant rewrite. Reticketed as https://github.com/getsentry/onpremise/issues/999.

Fixed this error by running Docker process first.

I guess we could add an explicit check for whether Docker is running? Or at least something to the docs to say "Make sure Docker is running"?