Onpremise: Rename onpremise to single-node

Created on 6 Jan 2021  Â·  9Comments  Â·  Source: getsentry/onpremise

Original:

In the docs we're using "self-hosted" to name what we're doing here. We should rename the repo, etc.(?) to match.

But now see https://github.com/getsentry/onpremise/issues/796#issuecomment-785168978 re: single-node.

Backlog Enhancement

Most helpful comment

Technically - no, not at all. I just didn't understand what the benefits of renaming would be. That's why I was a little :confused:

Anyway, there are also some other places that might need to be edited:

All 9 comments

I'm not sure if the effort is worth the benefits.

GitHub handles renames gracefully. The one lingering question I've had is forks, but it seems from testing (not seeing docs) that there's no issue with a fork of a renamed repo. The fork keeps the old name, _and_ its connection to the renamed parent. If anyone with a fork has the upstream set as a remote, GitHub redirection/aliasing ensures that they are unaffected—as long as we never break the redirect by creating a new onpremise repo.

tl;dr I think the effort is trivial.

Fork Test

Screen Shot 2021-01-06 at 4 54 56 PM

Alright, you know what, let's try this :)

@ingria Do you foresee problems with this? Why are you 😕?

Technically - no, not at all. I just didn't understand what the benefits of renaming would be. That's why I was a little :confused:

Anyway, there are also some other places that might need to be edited:

benefits

Less confusion. Right now we use two names—"on-premise," "self-hosted"—for the same thing. May not be worth it. Need to stew on this some more ... 🤔

The more I think about it, the more I don't like either name—onpremise or self-hosted—for this repo. I think a better name would be single-node, because it better captures our intention here: to package up _all_ of Sentry for deployment on a single node, in order to support a) proofs of concept for people evaluating SaaS, and b) small deployments for students, hobbyists, and small orgs. "Self-hosted" is broader as it really encompasses multi-node setups, too, which we don't officially support and never will (SaaS! SaaS!). Moreover, work that is relevant to self-hosters of any scale quite often (almost always?) impacts our other "primary" repos, e.g. #863 and #857 should really be against sentry, imo. We have a label in that repo to flag issues of particular (exclusive?) relevance to self-hosters.

This name may better reflect _how_ it's supposed to work, but it doesn't describe _what_ is this project for.

I mean, imagine you've just heard about some cool project called Gentry. And you'd like to know whether it's possible to use it on your own servers. How would you google it: "gentry self hosted" or "gentry single node"?

In other words, "single-node" is ok for a repo name, but not ok for a product name. Just my opinion, of course.

I agree with @ingria here, this was my main concern too. How about something like self-hosted-core or something as this setup _can_ be expanded into a multi-node setup through Docker Swarm or something like https://kompose.io/. Also AFAIK https://github.com/sentry-kubernetes/charts/ is tracking this repo for updates.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rmisyurev picture rmisyurev  Â·  4Comments

nature1995 picture nature1995  Â·  4Comments

wodCZ picture wodCZ  Â·  5Comments

6qiongtao picture 6qiongtao  Â·  4Comments

dotconnor picture dotconnor  Â·  6Comments