Onpremise: Add support for pulling images from a private repository

Created on 8 Jan 2020  路  7Comments  路  Source: getsentry/onpremise

Add support for an environment variable such as DOCKER_IMAGE_REPOSITORY that adds the repository as a prefix to all images if set. This would allow running the install script behind a firewall (that does have access to a private repository which proxies the request to the Docker Hub) without having to manually edit multiple files.

Enhancement help wanted

All 7 comments

Hi @Tirzono, I'm not familiar with this much or your specific use case. Would you mind sending a preliminary PR so we can work from there? I'm happy to make this happen if it doesn't complicate the codebase too much (sounds like it won't).

I am more than happy to send a PR for this. I think it won't complicate the codebase too much, but we will see that if I prepared the PR.

Good job on the release of version 10 by the way.

Good job on the release of version 10 by the way.

Thanks a lot, very much appreciated :)

I am more than happy to send a PR for this. I think it won't complicate the codebase too much, but we will see that if I prepared the PR.

Eagerly waiting for this. We are using Google Cloud Build at Sentry so maybe I can try testing with that once we get the PR up.

@Tirzono still interested?

I am still interested, but it is less of a priority as I got it working without the private repository too. I'm still planning to send a PR for this though.

@Tirzono - _still_ interested? 馃檪 Otherwise I'll close this issue as we are not planning to work on it ourselves.

Close it for now. I am still planning to do it but I haven't found time for it yet. If I will make a PR I will link it to this issue. We can always reopen it if needed. Thanks for your patience.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

6qiongtao picture 6qiongtao  路  4Comments

rmisyurev picture rmisyurev  路  4Comments

wodCZ picture wodCZ  路  5Comments

nature1995 picture nature1995  路  4Comments

marbon87 picture marbon87  路  5Comments