Online-go.com: Sorting gets broken on 'observe-games' page

[kobakitty]

Describe the bug
Correspondence games are not sorted by rank on "games" page. Also unchecking "bot games" will hide all games by professional accounts.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://online-go.com/observe-games
2. Click on "correspondence games" and uncheck "bot games" on the filter list
3. Scroll down and see that the sorting does not work and games by pros are hidden thanks to unchecking "bot games"
4. See error

Expected behavior
Seeing the games with strongest average rank at the top of the list. Also i would expect seeing pro games in the list, but for some reason those are counted as bot games.

Additional context
When i started typing this, the very top of corr games list is 1d vs 1d game (https://online-go.com/game/32286941) when "bot games" is unchecked. When including the bot games too, the strongest is 1p vs 5k (https://online-go.com/game/29264655)

[benjaminpjones]

Are there examples where pro v pro games are ranked below dan v dan? I imagine 5k v 1p could be prioritized below a 1d v 1d game if you are looking at min rank.

[mmartin]

Probably duplicate of https://github.com/online-go/online-go.com/issues/1351?

[kobakitty]

Are there examples where pro v pro games are ranked below dan v dan? I imagine 5k v 1p could be prioritized below a 1d v 1d game if you are looking at min rank.

No you dont understand, they are not below amateur games when bot games have been filtered, they simply are not there at the first place. Games where one or both players are pros will be filtered by unchecking that "bot games" filter.

And yes, all games where one or both players are pros are examples of this.

Also, thats kinda missing the point. OGS has many many correspondence games where both players have amateur ranks above 1d, but still that 1d vs 1d game was at the very top of the list.

Top corr games when bot games (thus also pro games) are included:

First are games where one player is pro, following games with highest average rank between players

And top games when bot games are filtered out:

When filtering out bot games, its randomly showing some of the recently started correspondences,