Oni: Ocaml Language Server not starting

[akinsho]

This issue is more likely than not an installation error but I've been fooling around a little with Reason and haven't been able to get the LSP to work in oni.

I've followed the install instructions from the reason-react website and it works in development but not in the packaged app I just get an error that says unable to spawn the lsp.

So far I haven't looked much at Oni LSP implementation so not sure if I've missed a configuration option or there might be an error somewhere.

I'm using the default config options (I haven't added any of my own)

[bryphe]

Oh wow - looks like we do have the wrong path for the language server in the packed version! Nice catch, @Akin909 .

The .bin folder doesn't make it into the packaged build, but we have this in our default config:

export const ocamllanguageserverpath = platform.iswindows()
    ? path.join(__dirname, "node_modules", ".bin", "ocaml-language-server.cmd")
    : path.join(__dirname, "node_modules", ".bin", "ocaml-language-server")

Might be part of the reason why the test to verify language services in a Reason file is failing (#1189) 🤔 Thanks for logging this issue!

[akinsho]

closed by #1380