Oni: Underscores aren't being displayed

[keforbes]

In the screenshot above, notice that the QuickInfo shows _pluginManager yet the word appears to be pluginManager with a space in front of it. For all those variables, there's supposed to be a _ between this. and the name. If you try typing a _ it looks like a space.

[bryphe]

Weird! Definitely a bug, thanks for the screenshot:

1) What OS is this?
2) Did you customize the font / font size? If so, what are the settings for that?

[bryphe]

Also, I wonder if the DOM rendering PR (#140) fixes this

[keforbes]

This is Linux, no customization to any fonts. Are you not able to reproduce it? Is this only me?

[bryphe]

Wasn't able to repro it on Windows! But I just tried on an Ubuntu Linux box and was able to repro, same behavior

[Rafi993]

I tried typing _ on oni and saved it and opened it in another editor it seems to be showing up in the file.

[Rafi993]

It is mostly electron rendering issue there was a simiar issue https://github.com/atom/atom/issues/8026 some time ago

[bryphe]

Looks like the DOM rendering PR i'm working on in #140 helps this

[keforbes]

Just updated and things look much better. I'm now only seeing the occasional issue where the underscore disappears when the cursor is on the line below the underscore. This causes underscores to flicker as I jjjjjj in a file. Test with the private variables declared at the beginning of the NeovimInstance class declaration.

[keforbes]

I'm not seeing the issue in my previous comment anymore. I don't know if it was due to upgrading Electron or some other change but that final issue is fixed.

[bryphe]

Awesome! It's possible the electron upgrade could've helped here, as they bumped up the renderer version and picked up the latest fixes from Chrome.

[hoschi]

I have the same thing, but with latest release v0.2.7

the text is

let overrideDetailProp = setPath(R.__, R.__, defaultDetailProps);

I'm also on Linux like @keforbes

[hoschi]

When I go into line selection mode (V) and back to normal mode I I see them with strange artifacts. Underscores and artifacts go away when I switch modes again or do something other.

[bryphe]

Thanks for the screenshots, @hoschi ! I have seen this occasionally, but not able to reproduce it consistently. I think the default color scheme hides it a bit - when I switch to another color scheme, the problem shows up more. So your screenshots were really helpful. Which colorscheme are you using, btw?

This is certainly a regression from the switch from DOM Rendering -> Canvas Rendering. It looks to me like there might be a rounding error when we're drawing / clearing some of the rectangles around text.

[bryphe]

In regards to the underscore - it looks like the text measurement may not be completely accurate. For the canvas rendering strategy, the character sizing has to be precise - I believe the character measuring logic might not be handling descenders correctly.

[hoschi]

@extr0py
I use a solarized theme:

set background=light
colorscheme solarized8_light_high

[cyansprite]

I also have this issue...
Whenever I use j and move past the line it disappears, but if use k and go back up it, it reappears...

If i click past it and don't touch the line, it doesn't affect it

Happens whether I use cursor line or not.

[bryphe]

This was fixed by PR #731 and is in the v0.2.10 release. Feel free to log a new issue if you're still seeing any render artifacts (this one is a bit overloaded 😄 )

[city41]

I am seeing a similar issue on Oni 0.3.4.

I am on Linux, and finding underscores don't really render anything. I can tell they are there because the next letter jumps ahead a space.

If I do a search for underscores ie /_<CR>, they highlight:

~~

EDIT: doh!, wait a minute, this file was set to filetype of markdown. False alarm.

[city41]

false alarm, I updated my comment above. sorry everyone :)