Oni: Can't build on OSX sierra

[metalelf0]

Hi, I'm trying to build master on osx 10.12.2 following the build instructions in the README file and it's failing with these errors:

metalelf0:oni/ (master) $ npm run build                                                                                                                                                                                                                              [10:04:25]

> [email protected] build /Users/metalelf0/sources/oni
> npm run build:browser && npm run build:plugin_api && npm run build:plugins


> [email protected] build:browser /Users/metalelf0/sources/oni
> webpack --config browser/webpack.production.config.js

ts-loader: Using [email protected] and /Users/metalelf0/sources/oni/browser/tsconfig.src.json
Hash: 7ae28ed3d5bc222dd09e
Version: webpack 1.14.0
Time: 5142ms
    Asset     Size  Chunks             Chunk Names
bundle.js  1.79 MB       0  [emitted]  main
   [0] multi main 28 bytes {0} [built]
    + 322 hidden modules

ERROR in ./browser/src/Plugins/PluginManager.ts
(284,31): error TS2345: Argument of type 'string | Buffer' is not assignable to parameter of type 'string'.
  Type 'Buffer' is not assignable to type 'string'.

ERROR in ./browser/src/Plugins/PluginManager.ts
Module build failed: Error: Typescript emitted no output for /Users/metalelf0/sources/oni/browser/src/Plugins/PluginManager.ts.
    at Object.loader (/Users/metalelf0/sources/oni/node_modules/ts-loader/dist/index.js:33:15)
 @ ./browser/src/index.tsx 10:24-58

> [email protected] build:plugin_api /Users/metalelf0/sources/oni
> cd plugin_api && tsc -p tsconfig.src.json


> [email protected] build:plugins /Users/metalelf0/sources/oni
> cd vim/core/oni-plugin-typescript && npm run build


> [email protected] build /Users/metalelf0/sources/oni/vim/core/oni-plugin-typescript
> npm install && tsc

npm WARN [email protected] No description
npm WARN [email protected] No repository field.
npm WARN [email protected] No license field.

I've also tried building v0.1.6 and v0.1.6.1, and I still get the same error. Obviously I have no local changes. I'm using node 7.3.0 and npm 3.10.10.

If you need further info please ask. Thanks for your time and keep up the great work!

[bryphe]

Thanks for the detailed report, @metalelf0

Looks like the latest version of TypeScript found an issue that previous versions didn't :) I have this fixed in PR #144

[metalelf0]

Thanks a lot, it builds correctly now ;) Great work!