Onesignal-ios-sdk: The app version is determined incorrectly

Created on 10 Nov 2017  路  3Comments  路  Source: OneSignal/OneSignal-iOS-SDK

Wrong in line 1013 of OneSignal.m:
NSString* build = [[NSBundle mainBundle]infoDictionary][(NSString*)kCFBundleVersionKey];

Correct is:
NSString* appVersion = [[[NSBundle mainBundle] infoDictionary] objectForKey:@"CFBundleShortVersionString"];

image-2017-11-06-17-40-54-036

Medium Priority

All 3 comments

@BlueFireCoder We will fix this in the next major release (3.0.0). Since this will be a breaking change for those who are relying on kCFBundleVersionKey we won't be able to make this change to a minor or patch version (2.x).

In the mean time I recommend using sendTag to track the app version if you need to use the CFBundleShortVersionString type instead.

Thanks.

Approximately when version 3.0.0 go out?

Closing issue with Major release beta being available

Was this page helpful?
0 / 5 - 0 ratings

Related issues

KishanVyas picture KishanVyas  路  6Comments

adambolcsfoldi picture adambolcsfoldi  路  4Comments

ogres picture ogres  路  3Comments

konkontos picture konkontos  路  3Comments

appcelerate picture appcelerate  路  3Comments