One: [doc] Circle Flatbuffers Graphical representation

Created on 27 Jul 2020  路  5Comments  路  Source: Samsung/ONE

I have created a Graphical representation based on the circle Flatbuffers schema.
I have saved in .jpg/.png format _(except BuiltinOperator and BuiltinOptions)_.

You can view it here.

Due to some other activity, I got busy and could not complete the BuiltinOptions part.

Let me know where (which path) can I upload the saved image?

Most helpful comment

@kishcs ,

Let me know where (which path) can I upload the saved image?

There has been no fixed position yet. I think /docs/diagrams/* would be nice if I decided now.

Other options:

  • I will try to create similar diagram with plantuml in future (at free time), which is opensource tool. It will be easy as well

Have you tried http://draw.io? It hasn't been used much yet, but ONE's official drawing tool is draw.io (https://github.sec.samsung.net/STAR/nnfw/issues/10118#issuecomment-517953). After drawing with this on-line, you can save it as editable png or svg.

Anyway, I am not sure if it is suitable for this use. It's your choice.

I have saved in .jpg/.png format (except BuiltinOperator and BuiltinOptions).

If this is an editable png and can be opened in draw.io, you can easily change the tool. :)

All 5 comments

@kishcs First of all, thank you for beautiful diagram.

  • I think it could be better if it can show how several indexes (buffer index, tensor index) is related, which is the important part to understand the schema. I am afraid it will make the diagram complex.
  • As schema is updated, we may need to update the diagram.

    • someone should be capable of editing this diagram.

    • it requires us maintenance cost.

Let me know where (which path) can I upload the saved image?

Which document will contain this diagram?

Thank you Mr Lee.

I think it could be better if it can show how several indexes (buffer index, tensor index) is related, which is the important part to understand the schema. I am afraid it will make the diagram complex.

I understand your concern. Do we get the info about the relation of indexes in the schema? If its there, then I can represent it in diagram. Let me know how to retrieve that from schema file.

As schema is updated, we may need to update the diagram.
someone should be capable of editing this diagram.

Yes, You are right. We need to update the diagram as and when schema is updated. We should map with the version number of schema.
As of now I have used miro to draw the diagram, which is free tool for max 3 members. If we agree upon to continue on editing the diagram on miro, then I can add two people as collaborator.

Other options:

  • I will try to create similar diagram with plantuml in future (at free time), which is opensource tool. It will be easy as well to update the diagram.
  • Also I will try to create a script which will read schema and create plantuml file. (Lots of work)

it requires us maintenance cost.

As it is not of priority, so based on someone's interest, anyone can update the diagram.

Which document will contain this diagram?

I am not sure about this, So only I asked like where should I put the diagram.
May be in Compiler doc OR in the same path where we have sequence diagrams.

@kishcs Okay. Thank you for answer. I would like to hear other's opinion, especially for compiler part and @lemmaa.

@kishcs ,

Let me know where (which path) can I upload the saved image?

There has been no fixed position yet. I think /docs/diagrams/* would be nice if I decided now.

Other options:

  • I will try to create similar diagram with plantuml in future (at free time), which is opensource tool. It will be easy as well

Have you tried http://draw.io? It hasn't been used much yet, but ONE's official drawing tool is draw.io (https://github.sec.samsung.net/STAR/nnfw/issues/10118#issuecomment-517953). After drawing with this on-line, you can save it as editable png or svg.

Anyway, I am not sure if it is suitable for this use. It's your choice.

I have saved in .jpg/.png format (except BuiltinOperator and BuiltinOptions).

If this is an editable png and can be opened in draw.io, you can easily change the tool. :)

Thanks Mr. Lee. Sure I will check the path.

Have you tried http://draw.io? It hasn't been used much yet, but ONE's official drawing tool is draw.io

I have not used _draw.io_ earlier, but definitely I will check it out.
If this has text format to generate diagrams, that will be helpful like in _plantuml_.

If this is an editable png and can be opened in draw.io, you can easily change the tool. :)

Currently it's not editable png. But I will create editable once I update with _draw.io_ or _plantuml_

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mhs4670go picture mhs4670go  路  4Comments

periannath picture periannath  路  3Comments

underflow101 picture underflow101  路  4Comments

mhs4670go picture mhs4670go  路  3Comments

jinevening picture jinevening  路  3Comments