- Add tests for KernelBuilder.
- Check output shapes in kernel tests.
- Improve checks for consistency of types and shapes in
configureandexecute. - Add negative kernel tests.
typtechnical debt
s-barannikov
👍2
All 5 comments
What is type/technical debt and why did you add this label?
seanshpark
on 19 May 2020
Basically speaking, it is the work which should have been done right away, but for some reasons has been posponed. Please check out the wikipedia article for more.
I used this label because the items in the list should be implemented, but they are not that critical to do it right now.
s-barannikov
on 19 May 2020
👍3
@s-barannikov Is it okay for you if I create functions in testutil for output tensor shape check?
struss
on 19 Jun 2020
@struss
Sure. I just have one wish: it would be nice to see what exactly differs in shapes in case a test fails.
s-barannikov
on 19 Jun 2020
@s-barannikov okay. I will make a draft PR for this. thanks a lot.
struss
on 19 Jun 2020
Was this page helpful?
0 / 5 - 0 ratings
Related issues
kishcs
路
3Comments
dr-venkman
路
4Comments
wateret
路
4Comments
ragmani
路
4Comments
mhs4670go
路
4Comments
Most helpful comment
Basically speaking, it is the work which should have been done right away, but for some reasons has been posponed. Please check out the wikipedia article for more.
I used this label because the items in the list should be implemented, but they are not that critical to do it right now.