CI builds and tests nncc every PR. But it makes us spends too much time building and testing. So, it is better to do a long test(e.g. tf2tfliteV2 test takes like 5 minutes), not every PR, just periodically.
There are a few options I think.
Reduce build time
We can make a white list which is created by gathering frequently used(need to discusstion) or necessary to releases.
then,
every PR build - build with white list
push build - build all module
Reduce test time
We can add command to ./nncc test like below.
./nncc test -E ".*_remote_test|tf2tfliteV2_.*"
then,
every PR build - test with above command
push build - test all module
Second option looks good to me but first option looks a little bit optional.
Please give your opinion:)
I'm not sure, but you may skip build tf2tfliteV2 with -DBUILD_COMPILER_TF2TFLITEV2=OFF:
https://github.com/Samsung/ONE/blob/9a72d12281e50d60af67fb46b7d2dfff3d1ae9ed/compiler/CMakeLists.txt#L43
What is the distinction between PR build and push build?
@s-barannikov it is build type. former builds with debug, latter builds with release. Well, the person in charge said that server pool will be added to cover more jobs soon. So, as of now, there will be no change.
Most helpful comment
I'm not sure, but you may skip build
tf2tfliteV2with-DBUILD_COMPILER_TF2TFLITEV2=OFF:https://github.com/Samsung/ONE/blob/9a72d12281e50d60af67fb46b7d2dfff3d1ae9ed/compiler/CMakeLists.txt#L43