Omr: Rename NonHelper to Intrinsic?

Created on 12 Oct 2018  路  5Comments  路  Source: eclipse/omr

In the discussion of #2997 and #3049, as well as development of atomic operation support, I found the name of "NonHelper" is quite confusing. They look alike to helper methods but not a real helper because CodeGen is expected to generate inlined sequences instead of a helper call. Similar concept is known as "intrinsic" or "intrinsic method/function" in many other compilers.
Should we change the concept of "NonHelper" to "Intrinsic", or some other name that less confusing?

compiler discussion

Most helpful comment

I think a question such as this deserves to go on the agenda of one of the architecture meetings. @0xdaryl

All 5 comments

For example change the enum CommonNonhelperSymbol to CommonIntrinsicSymbol.

@0xdaryl @andrewcraik @fjeremic @Leonardo2718 @mstoodle @ymanton

I think a question such as this deserves to go on the agenda of one of the architecture meetings. @0xdaryl

I agree the term "NonHelper" is confusing. I'm in favor of renaming to "Intrinsic". I also agree we should bring this up on the architecture meeting discussing the topic.

I'd like to move this discussion to today's architecture meeting: @0dvictor @ymanton @fjeremic @andrewcraik @gita-omr @Leonardo2718 @vijaysun-omr

Was this page helpful?
0 / 5 - 0 ratings