Omnisharp-vscode: Release the "download external dependencies" code as a standalone package

Created on 15 May 2020  路  4Comments  路  Source: OmniSharp/omnisharp-vscode

This extension seems to have a strong mechanism for downloading external dependencies, how about to release this part of code as a standalone npm package for other extensions to use?

This approach can also be a solution for https://github.com/microsoft/vscode/issues/23251.

Installation Triaged

Most helpful comment

Ultimately we would like to delete our dependency downloading code in favor of: https://github.com/microsoft/vscode/issues/23251

All 4 comments

The goal here is definitely fine. We want to decouple some of these dependencies from the plugin and factor them into individual plugins that this plugin will take a dependency on (e.g., .NET Core plugin, .NET Core debugger plugin, etc.)

Ultimately we would like to delete our dependency downloading code in favor of: https://github.com/microsoft/vscode/issues/23251

Your dependency downloading code can still be useful in other scenarios.

To have platform-specific extensions certainly solves most of the problem, since we could simply package all the needed binaries into the .vsix.

One thing to note is: some licenses don't allow binary redistribution, which in this case we would still need a mechanism for downloading the dependencies.

From https://github.com/microsoft/vscode/issues/23251#issuecomment-638323440.

Yes, I am not saying that such code shouldn't exist anywhere in the universe, but this issue was opened as a request for this extension to pull out the dependency download code. The source code in this extension is MIT licensed, so anyone is welcome to take the code and make an NPM package themselves. But I am skeptical that it makes sense for the owners of this extension to be involved since we hope to stop using such code soon.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ZeldaZocker picture ZeldaZocker  路  3Comments

Alumniminium picture Alumniminium  路  3Comments

jwbay picture jwbay  路  3Comments

mattwoberts picture mattwoberts  路  3Comments

mshinnie picture mshinnie  路  3Comments