Omnisharp-vscode: Complains about existing definition in same namespace

[MikaelUmaN]

Issue Type: Bug

Not really sure how to reproduce unfortunately...

This happens intermittently. My best guess is that it is due to renaming.

• Create C# project via terminal: dotnet new ...
• In file explorer, create folder MyNameSpace
• Create file with some name, e.g. an enum
• Rename symbol

Expected:
Still compiles and no warnings in editor

Actual:
Compiles, but warnings in editor:

The namespace 'BackEndWebApi.InstrumentRefData.Model' already contains a definition for 'ESeriesType' [BackEndWebApi]

After restart, it works without complaints. Really hard to give a good "reproduce" but I keep running into this when I am moving files, changing namespaces and what not (due to just experimenting with project structure)

Extension version: 1.17.1
VS Code version: Code 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-07T22:54:13.295Z)
OS version: Windows_NT x64 10.0.17134

System Info

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-7660U CPU @ 2.50GHz (4 x 2496)|
|GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled|
|Memory (System)|15.93GB (8.82GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|

[akshita31]

@MikaelUmaN Can you share your OmniSharp log when this happens.

[RononDex]

I have the same thing happening. The OmniSharp log does not show anything (no output since loading / updating the .csproj files).

I got this issue a few times after moving files. To me it looks like Onmisharp parses the moved file as a new file (and therefore thinks the class / class members are defined twice), without "removing" the parsed contents of the "old" file

UPDATE:
I also run across this bug when opening big solutions.
Happens with files that are already open. Again seems like files that are already open in the editor are parsed once and once when the .sln file is loaded. So it sometimes thinks that types are defined twice

[akshita31]

@RononDex What is the extension version that you are using ?

[rchande]

@RononDex @MikaelUmaN We have a beta that we believe address the "files that move result in errors" behavior. Give it a try from https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.18.0-beta5 and let us know if it helps.

[RononDex]

@rchande have been working with the latest build of omnisharp-roslyn (compiled it myself) for a day now, so far the bug didn't show up, so I guess thats a good sign :)

Really looking forward to the roslyn-analyzers PR

[rchande]

@MikaelUmaN It sounds like this is fixed--I'm going to close the bug. Go ahead and further comments if you have any.

[teqdruid]

--- Edit: Nevermind. This was my issue. Did not realize that a namespace could conflict with a class. Now how it was ever compiling is a mystery to me but doubtless, that was due to another stupid mistake on my part. Sorry for the noise.