Ombi: Request Added Notification issue

[cesalo]

Ombi Version:

Application Version: 2.0.1223
OS: Mono
System Version: 4.2.2 (Stable 4.2.2.30/996df3c Fri Jan 29 21:11:18 CET 2016)
Branch: Stable
Log Level: Error
Database Location: /share/CACHEDEV1_DATA/.qpkg/Ombi/Release/Ombi.sqlite
Running Directory: /share/CACHEDEV1_DATA/.qpkg/Ombi/Release

Operating System:

QNAP

Problem Description:

It seems "Request Added Notification" is not working. When I mark a movie as available the person that requested it is not getting any notification. I assume the idea of this feature is that people requesting movies/tvshows get notification once is added.

Ombi is sending notifications when movies are added and also tested the newsletter so the SMTP settings are fine.

These are not plex users but local users and have e-mails assigned.

Reproduction Steps:

User requests movie and has the feature "Request Added Notification" enabled.
Movies is marked as available.
User is not getting notification.

[Ombi-robot]

Hi!
Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.
Before posting make sure you also read our FAQ and known issues.
Make the title describe your issue. Having "not working" or "I get this bug" for 100 issues, isn't really helpful.
If we need more information or there is some progress we tag the issue or update the tag and keep you updated.
Cheers!
Ombi Support Team

[cesalo]

Sorry by this: "Ombi is sending notifications when movies are added" I meant when people is requesting movies.

[tidusjar]

Sorry I am confused, what's the issue?

[cesalo]

user is not getting notification when a movie he/she requested is added.

[tidusjar]

In your Email Notification Settings,

The Enable user email notifications setting is checked?

[cesalo]

Yes, it's enabled.

[PotatoQuality]

Does the test mail works? Can you post your logs?

[cesalo]

Yes, the test e-mail works.

[cesalo]

ombi_logs.txt

For some reason couldn't upload the logs as a zip file. Please change the extension of the file from txt to zip.

[rulles]

Hello,

I have the same problem, the test email work fine, the admin notification email when some user do some request work fine, only the user email notification when their request was added not work.

Ombi Version:

Application Version: 2.0.1234
OS: Mono
System Version: 4.6.2 (Stable 4.6.2.16/ac9e222 Tue Jan 3 11:51:14 UTC 2017)
Branch: Stable
Log Level: Debug

Operating System:

CentOS 7

Log:

2017/01/25 11:00:04.892 Ombi.Services.Jobs.PlexAvailabilityChecker Debug: Requests that will be updated count 1
2017/01/25 11:00:05.383 Ombi.Services.Notification.NotificationEngine Debug: Notifying Users Count 34
2017/01/25 11:00:05.386 Ombi.Services.Notification.NotificationEngine Error: System.NullReferenceException: Object reference not set to an instance of an object
at Ombi.Services.Notification.NotificationEngine+<>c__DisplayClass14_1.b__1 (Ombi.Core.Users.UserHelperModel x) [0x0001a] in <9a0d9dc8d682482f8df1a85d63417e3a>:0
at System.Linq.Enumerable.FirstOrDefault[TSource] (System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] predicate) [0x00035] in <63992662b765477a898ef49cdcc99ee2>:0
at Ombi.Services.Notification.NotificationEngine+d__14.MoveNext () [0x002a2] in <9a0d9dc8d682482f8df1a85d63417e3a>:0 System.NullReferenceException: Object reference not set to an instance of an object
at Ombi.Services.Notification.NotificationEngine+<>c__DisplayClass14_1.b__1 (Ombi.Core.Users.UserHelperModel x) [0x0001a] in <9a0d9dc8d682482f8df1a85d63417e3a>:0
at System.Linq.Enumerable.FirstOrDefault[TSource] (System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] predicate) [0x00035] in <63992662b765477a898ef49cdcc99ee2>:0
at Ombi.Services.Notification.NotificationEngine+d__14.MoveNext () [0x002a2] in <9a0d9dc8d682482f8df1a85d63417e3a>:0

[tidusjar]

Can you try the latest EAP build?

[rulles]

Hello.
Before i change to the last stable version, i use the last eap and the
problem is the same.
Sincerely, i prefer keep the stable version instead of eap version.

But i can install to try.

Jamie [e-mail] escreveu em qui, 26/01/2017 às 08:05 :

Can you try the latest EAP build?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275328914, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zj97KayiSOpTyzSZK6KAUNkF7K2Fks5rWFPegaJpZM4LsXT6
.

>

(Enviado do iPhone) Atenciosamente/ With best Regards, António Pinto

[tidusjar]

@rulles Yeah I understand, so you used version 2.0.1293 and it was still an issue?

[rulles]

I don't know what version was my last setup of eap. Eap have updates almost
or every day. I try eap 2 or 3 days ago, and cannot send users email
notifications too so i change to stable in hope that resolve, but have the
same issue.

Instead i change to last eap version, you can tell me what file or files
and what i need to change in stable version to send users emails
notifications and i try that, if that is possible.

Jamie [e-mail] escreveu em qui, 26/01/2017 às 08:16 :

@rulles https://github.com/rulles Yeah I understand, so you used
version 2.0.1293 and it was still an issue?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275330380, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zui5cYvmdhydPPTNs5wtTA_Q6_A5ks5rWFZJgaJpZM4LsXT6
.

>

(Enviado do iPhone) Atenciosamente/ With best Regards, António Pinto

[rulles]

Hello,

I change now to EAP version 2.0.1293 and the users email notification when
some request was added not send too.

Log:

2017/01/26 10:49:22.173 Ombi.Services.Jobs.PlexAvailabilityChecker Debug:
Requests that will be updated count 1
2017/01/26 10:49:22.649 Ombi.Services.Notification.NotificationEngine
Debug: Notifying Users Count 31
2017/01/26 10:49:22.652 Ombi.Services.Notification.NotificationEngine
Error: System.NullReferenceException: Object reference not set to an
instance of an object
at
Ombi.Services.Notification.NotificationEngine+<>c__DisplayClass14_1.b__1
(Ombi.Core.Users.UserHelperModel x) [0x0001a] in
<4dba76e1758e41ef86f6c7024cfb5924>:0
at System.Linq.Enumerable.FirstOrDefault[TSource]
(System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] predicate) [0x00035] in
<63992662b765477a898ef49cdcc99ee2>:0
at
Ombi.Services.Notification.NotificationEngine+d__14.MoveNext
() [0x002a2] in <4dba76e1758e41ef86f6c7024cfb5924>:0
System.NullReferenceException: Object reference not set to an instance of
an object
at
Ombi.Services.Notification.NotificationEngine+<>c__DisplayClass14_1.b__1
(Ombi.Core.Users.UserHelperModel x) [0x0001a] in
<4dba76e1758e41ef86f6c7024cfb5924>:0
at System.Linq.Enumerable.FirstOrDefault[TSource]
(System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] predicate) [0x00035] in
<63992662b765477a898ef49cdcc99ee2>:0
at
Ombi.Services.Notification.NotificationEngine+d__14.MoveNext
() [0x002a2] in <4dba76e1758e41ef86f6c7024cfb5924>:0

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 9:18 GMT+00:00 Antonio Pinto [e-mail]:

I don't know what version was my last setup of eap. Eap have updates
almost or every day. I try eap 2 or 3 days ago, and cannot send users email
notifications too so i change to stable in hope that resolve, but have the
same issue.

Instead i change to last eap version, you can tell me what file or files
and what i need to change in stable version to send users emails
notifications and i try that, if that is possible.

Jamie [e-mail] escreveu em qui, 26/01/2017 às 08:16 :

@rulles https://github.com/rulles Yeah I understand, so you used
version 2.0.1293 and it was still an issue?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275330380, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zui5cYvmdhydPPTNs5wtTA_Q6_A5ks5rWFZJgaJpZM4LsXT6
.

>

(Enviado do iPhone) Atenciosamente/ With best Regards, António Pinto

[tidusjar]

Do you mind if I give you a build with more debug information so I can track this down?

Also do you know what request this is? In the requests page, does it show who requested it?

[rulles]

Yes.
I can see who did that request.
And after the cronjob run, the request change to available.

Jamie [e-mail] escreveu em qui, 26/01/2017 às 11:21 :

Do you mind if I give you a build with more debug information so I can
track this down?

Also do you know what request this is? In the requests page, does it show
who requested it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275365842, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zi8cpxp99qM_9VYVHQEP-ckb-kd5ks5rWIGzgaJpZM4LsXT6
.

>

(Enviado do iPhone) Atenciosamente/ With best Regards, António Pinto

[tidusjar]

Can you try this build? There is more debug information for me to work out what the issue is:

https://ci.appveyor.com/project/tidusjar/requestplex/branch/dev/artifacts

[rulles]

I change now to that version you send.

I will do some tests and send you the logs.

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 11:45 GMT+00:00 Jamie [e-mail]:

Can you try this build? There is more debug information for me to work out
what the issue is:

https://ci.appveyor.com/project/tidusjar/requestplex/branch/dev/artifacts

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275369984, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zv3ahZ5UxefGxP_OIwZnzxeViIz9ks5rWIdkgaJpZM4LsXT6
.

[rulles]

Hello.

With this version i already send the notification.

So, can i keep this version or you will release some stable version with
this changes?

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 17:02 GMT+00:00 Antonio Pinto [e-mail]:

I change now to that version you send.

I will do some tests and send you the logs.

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 11:45 GMT+00:00 Jamie [e-mail]:

Can you try this build? There is more debug information for me to work
out what the issue is:

https://ci.appveyor.com/project/tidusjar/requestplex/branch/dev/artifacts

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275369984, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zv3ahZ5UxefGxP_OIwZnzxeViIz9ks5rWIdkgaJpZM4LsXT6
.

[rulles]

Sorry, i was a mistake, cannot send like others. But send without problems
if i manually mark that request as available, have error only if this is
doing by the cronjob.

2017/01/26 17:22:22.777 Ombi.Services.Notification.NotificationEngine
Debug: Notifying Users Count 31
2017/01/26 17:22:22.780 Ombi.Services.Notification.NotificationEngine
Error: System.NullReferenceException: Object reference not set to an
instance of an object
at
Ombi.Services.Notification.NotificationEngine+<>c__DisplayClass14_1.b__1
(Ombi.Core.Users.UserHelperModel x) [0x0001a] in
:0
at System.Linq.Enumerable.FirstOrDefault[TSource]
(System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] predicate) [0x00035] in
<63992662b765477a898ef49cdcc99ee2>:0
at
Ombi.Services.Notification.NotificationEngine+d__14.MoveNext
() [0x002a2] in :0
System.NullReferenceException: Object reference not set to an instance of
an object
at
Ombi.Services.Notification.NotificationEngine+<>c__DisplayClass14_1.b__1
(Ombi.Core.Users.UserHelperModel x) [0x0001a] in
:0
at System.Linq.Enumerable.FirstOrDefault[TSource]
(System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] predicate) [0x00035] in
<63992662b765477a898ef49cdcc99ee2>:0
at
Ombi.Services.Notification.NotificationEngine+d__14.MoveNext
() [0x002a2] in :0

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 17:17 GMT+00:00 Antonio Pinto [e-mail]:

Hello.

With this version i already send the notification.

So, can i keep this version or you will release some stable version with
this changes?

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 17:02 GMT+00:00 Antonio Pinto [e-mail]:

I change now to that version you send.

I will do some tests and send you the logs.

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 11:45 GMT+00:00 Jamie [e-mail]:

Can you try this build? There is more debug information for me to work
out what the issue is:

https://ci.appveyor.com/project/tidusjar/requestplex/branch/
dev/artifacts

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275369984,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zv3ahZ5UxefGxP_OIwZnzxeViIz9ks5rWIdkgaJpZM4LsXT6
.

[rulles]

Hello.

Already have some ideia about what is wrong?

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 17:26 GMT+00:00 Antonio Pinto [e-mail]:

Sorry, i was a mistake, cannot send like others. But send without problems
if i manually mark that request as available, have error only if this is
doing by the cronjob.

2017/01/26 17:22:22.777 Ombi.Services.Notification.NotificationEngine
Debug: Notifying Users Count 31
2017/01/26 17:22:22.780 Ombi.Services.Notification.NotificationEngine
Error: System.NullReferenceException: Object reference not set to an
instance of an object
at Ombi.Services.Notification.NotificationEngine+<>c__
DisplayClass14_1.b__1 (Ombi.Core.Users.UserHelperModel x)
[0x0001a] in :0
at System.Linq.Enumerable.FirstOrDefault[TSource]
(System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] predicate) [0x00035] in <
63992662b765477a898ef49cdcc99ee2>:0
at Ombi.Services.Notification.NotificationEngine+d__14.MoveNext
() [0x002a2] in :0 System.NullReferenceException:
Object reference not set to an instance of an object
at Ombi.Services.Notification.NotificationEngine+<>c__
DisplayClass14_1.b__1 (Ombi.Core.Users.UserHelperModel x)
[0x0001a] in :0
at System.Linq.Enumerable.FirstOrDefault[TSource]
(System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] predicate) [0x00035] in <
63992662b765477a898ef49cdcc99ee2>:0
at Ombi.Services.Notification.NotificationEngine+d__14.MoveNext
() [0x002a2] in :0

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 17:17 GMT+00:00 Antonio Pinto [e-mail]:

Hello.

With this version i already send the notification.

So, can i keep this version or you will release some stable version with
this changes?

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 17:02 GMT+00:00 Antonio Pinto [e-mail]:

I change now to that version you send.

I will do some tests and send you the logs.

Atenciosamente/ With best Regards,
António Pinto

2017-01-26 11:45 GMT+00:00 Jamie [e-mail]:

Can you try this build? There is more debug information for me to work
out what the issue is:

https://ci.appveyor.com/project/tidusjar/requestplex/branch/
dev/artifacts

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275369984,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zv3ahZ5UxefGxP_OIwZnzxeViIz9ks5rWIdkgaJpZM4LsXT6
.

[tidusjar]

@rulles I have not had time to look into this yet. I plan to spend some of my spare time looking into this, this weekend.

I will update this once I have any more information. Please keep in mind that I work on Ombi in my spare time, I have a full time job, a 3 month old baby and other things in my life that also take up time.

[rulles]

Hello,

Sorry if you understand me wrong, my point is put that notifications work
for me and all of your users and most of all help you understand whats is
going wrong.

Sorry if i'm too "boring".

Atenciosamente/ With best Regards,
António Pinto

2017-01-27 9:51 GMT+00:00 SuperPotatoMen [e-mail]:

I'm sorry but that is inappropriate

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275627658, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9ZiVO0dhahPoaf-8ZupgiLcyS7Jyaks5rWb4ggaJpZM4LsXT6
.

[rulles]

Jamie, i know everybody have life out of this project, but i only ask for
some update to help with the problem or do more some tests if you need them.

I know this is a non comercial software, and of course i want this working,
but like a said, i only ask for update to help understand what is wrong and
help you.

Sorry if i was misunderstanding.

Atenciosamente/ With best Regards,
António Pinto

2017-01-27 9:56 GMT+00:00 Jamie [e-mail]:

@rulles https://github.com/rulles I have not had time to look into this
yet. I plan to spend some of my spare time looking into this, this weekend.

I will update this once I have any more information. Please keep in mind
that I work on Ombi in my spare time, I have a full time job, a 3 month old
baby and other things in my life that also take up time.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275628651, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9ZjWHlv6MWD1XLhWTXiMzdei8rCvwks5rWb9SgaJpZM4LsXT6
.

[tidusjar]

That's fine, don't worry about it!

So with the latest logs you posted. Is that from the new build that I sent you?

[rulles]

Yes.
Is the log the last build you send me.

Jamie [e-mail] escreveu em sex, 27/01/2017 às 21:25 :

That's fine, don't worry about it!

So with the latest logs you posted. Is that from the new build that I sent
you?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275778818, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9ZhAbW0KoCUJygJHenuxUBuaLgqHwks5rWmDUgaJpZM4LsXT6
.

>

(Enviado do iPhone) Atenciosamente/ With best Regards, António Pinto

[tidusjar]

That sucks.

Can you please change your admin password and email me your database so I can inspect the data and fix this issue? [email protected]

The database is the .SQLite file. It's either called Ombi.sqlite or PlexRequests.sqlite

[rulles]

You really need my database?! Have a lot of information there, like the
login to may plex server, smtp data, etc.

[tidusjar]

I just need to see the PlexUsers table and Users table to see if I can debug the issue.

If you are concerned about your data you could backup your database file, go into ombi, remove all the personal information then send me that file? Just remember to replace it with your backup so you don't loose your information.

[rulles]

Ok.
In this weekend i cannot send you, but i will try. Other wise i send you in
monday morning.

Em 27/01/2017 23:58, "Jamie" [e-mail] escreveu:

I just need to see the PlexUsers table and Users table to see if I can
debug the issue.

If you are concerned about your data you could backup your database file,
go into ombi, remove all the personal information then send me that file?
Just remember to replace it with your backup so you don't loose your
information.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275806446, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zj3BRku9OGxFgXa5dcFi4RZGD3nGks5rWoSWgaJpZM4LsXT6
.

--
(Enviado do iPhone) Atenciosamente/ With best Regards, António Pinto

[tidusjar]

That's fine. Thanks

[rulles]

Hello,

I already send the database to your email.

Atenciosamente/ With best Regards,
António Pinto

2017-01-28 0:12 GMT+00:00 Jamie [e-mail]:

That's fine. Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-275808403, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zo-loHIceiB9RXWhgzV63dTJhHpDks5rWofkgaJpZM4LsXT6
.

[tidusjar]

Found the issue! The latest EAP will fix this!

[rulles]

Nice.

Can you tell me what was the problem?! And when will be available the that
release?!

Jamie [e-mail] escreveu em seg, 30/01/2017 às 12:56 :

Found the issue! The latest EAP will fix this!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-276056037, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9Zjym1yq7mJAmX2iRrppf6RHUKdDLks5rXd4FgaJpZM4LsXT6
.

>

(Enviado do iPhone) Atenciosamente/ With best Regards, António Pinto

[PotatoQuality]

@rulles You can switchs to the EAP branch if you like. Otherway, when EAP is stable it will be push to stable/master branch.

[tidusjar]

@rulles The issue was that for some reason one of your users the Alias was null rather than an empty string. So I have added some protective code around this.

[rulles]

Ok. Thanks.

Jamie [e-mail] escreveu em seg, 30/01/2017 às 13:00 :

@rulles https://github.com/rulles The issue was that for some reason
one of your users the Alias was null rather than an empty string. So I
have added some protective code around this.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tidusjar/Ombi/issues/985#issuecomment-276056741, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANb9ZjFbv51SFlCPsSwLpWHy4Bi8UhzIks5rXd71gaJpZM4LsXT6
.

>

(Enviado do iPhone) Atenciosamente/ With best Regards, António Pinto

[erodewald]

Not trying to reopen this issue but I can't find the "user email notifications" in stable or EAP.

(stable: 2.1.0, eap: 2.1.1401)

Was it pulled, or did I not set something up correctly?