Okhttp: Add module-info.java

[hrchu]

So that projects depend on this can be published to a public artifact repository.
Note that this is not breaking backward compatibility. All codes except this file can be still compiled in Java 6.

[JakeWharton]

I don't see how publishing to a public artifact repository and becoming a
module jar are correlated.

On Wed, Oct 18, 2017, 3:52 AM hrchu [e-mail] wrote:

So that projects depend on this can be published to a public artifact
repository.
Note that this is not breaking backward compatibility. All codes except
this file can be still compiled in Java 6.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/issues/3655, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEb54bHoM8K9PghQW85XsZwBBlXnuks5sta4zgaJpZM4P9TIu
.

[yschimke]

Does seem like something we should do.

http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html

Along with additionally building against released JDK 9 in https://github.com/square/okhttp/blob/master/.travis.yml

[JakeWharton]

Oh I'm all for an automatic module name. But I see no reason to add a
module-info.class entry.

On Wed, Oct 18, 2017 at 11:55 AM Yuri Schimke [e-mail]
wrote:

Does seem like something we should do.

http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html

Along with additionally building against released JDK 9 in
https://github.com/square/okhttp/blob/master/.travis.yml

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/issues/3655#issuecomment-337638759, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEEETwucSMzypw1PsuVxu4CFuRy0IeHks5sth9WgaJpZM4P9TIu
.

[hrchu]

@JakeWharton the problem is that projects depends on filename-based automodules should not be published to a public artifact repository.

At least we need add Automatic-Module-Name entry to JAR's manifest.
https://github.com/google/guava/commit/f2be0be06ef49dee7c5dfcb3a0231c5ecaf5b621#diff-e407b6f223ee6c04116a91ead9f5e100R42

Refer: https://github.com/grpc/grpc-java/issues/3523

[JakeWharton]

That's what I said, yeah. But why are you recommending a module-info.class
entry?

On Wed, Oct 18, 2017 at 9:53 PM hrchu [e-mail] wrote:

@JakeWharton https://github.com/jakewharton the problem is that
projects depends on filename-based automodules should not be published to a
public artifact repository.

At least we need add Automatic-Module-Name entry to JAR's manifest.
google/guava@f2be0be#diff-e407b6f223ee6c04116a91ead9f5e100R42
https://github.com/google/guava/commit/f2be0be06ef49dee7c5dfcb3a0231c5ecaf5b621#diff-e407b6f223ee6c04116a91ead9f5e100R42

Refer: grpc/grpc-java#3523 https://github.com/grpc/grpc-java/issues/3523

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/issues/3655#issuecomment-337776700, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEEEYjzrk2ka7oDWE6bpg3GoB6_Dxdeks5stquOgaJpZM4P9TIu
.

[hrchu]

I change my mind. Automatic-Module-Name is good enough currently.

[yschimke]

https://github.com/square/okhttp/pull/3743

[yschimke]

Per https://github.com/square/okhttp/pull/3743#issuecomment-363851149

We should (ideally) clean up package names to not overlap when doing this.

cc @jodastephen

[swankjesse]

Done.

[devsh0]

Newbie here. Can't create a custom JRE using jlink without module-info.java. I use OkHTTP in almost all my projects. Would be great if I didn't have to manually unpack and recompile everything with module-info.java.