Oj: Explicit type check on parse parameter

[paradox460]

Currently, when running in mimic_json or rails mode, Oj appears to do a hard-check on the argument passed to JSON.parse, and raises an ArgumentError if it is not a String or IO object.

This is a deviation from the standard lib JSON.parse, which allows for any string-like or IO-like object. Many gems and libraries have used (abused?) this feature.

---

Test case:

require 'oj'

Oj.mimic_JSON
Oj.add_to_json

class StringPlus

  def initialize(str)
    @str = str
  end
  def to_str
    @str
  end
  alias to_s to_str
end

test_str = StringPlus.new('{"testing": 123}')
JSON.parse(test_str)

[ohler55]

Ouch, ok, I'll test the json gem and update Oj in mimic mode to handle that with a call to to_s and check for what ever IO methods are needed before that.

[paradox460]

Great! Thanks for the fast response!

[ohler55]

Might take a day or two.

[ohler55]

or maybe less. :-) please try the latest master.

[ohler55]

3.0.9 released

[paradox460]

Checking it now, preliminary test seem to indicate success

[ohler55]

Can this be closed?

[paradox460]

Yep, sorry, it works perfectly!