Oidc-client-js: Typescript build issue in 1.7.0-beta.1

[dmmusil]

Thanks for the update on my previous issue. I checked out the beta today and it works great. One issue I ran into is that the type definitions cause an issue during the build.

$ yarn run tsc
yarn run v1.1.0
$ "C:\repo\bitbucket.org\dylanmusil\oidc\node_modules\.bin\tsc"
node_modules/oidc-client/index.d.ts:254:21 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.

254   new (url: string, delimiter: string = '#'): SigninResponse;
                        ~~~~~~~~~~~~~~~~~~~~~~~

node_modules/oidc-client/index.d.ts:261:3 - error TS2300: Duplicate identifier 'expires_in'.

261   expires_in: number;
      ~~~~~~~~~~

node_modules/oidc-client/index.d.ts:261:3 - error TS2687: All declarations of 'expires_in' must have identical modifiers.

261   expires_in: number;
      ~~~~~~~~~~

node_modules/oidc-client/index.d.ts:270:12 - error TS2300: Duplicate identifier 'expires_in'.

270   readonly expires_in: number | undefined;
               ~~~~~~~~~~

node_modules/oidc-client/index.d.ts:270:12 - error TS2687: All declarations of 'expires_in' must have identical modifiers.

270   readonly expires_in: number | undefined;
               ~~~~~~~~~~


Found 5 errors.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Repro here: https://github.com/dmmusil/oidc-client-beta/tree/master

[brockallen]

The duplicate expires_in I think I already fixed. Can you look at latest from dev?

[brockallen]

For the other, you can submit a PR, please/

[dmmusil]

@brockallen any chance we can get an updated beta or RC with this PR in it?

[brockallen]

does this not have it?

https://www.npmjs.com/package/oidc-client/v/1.7.0-beta.1

[dmmusil]

does this not have it?

Correct. This issue and the PR were in response to the beta.1 release.

[brockallen]

ah ok -- i missed when it was. i have a TODO item to release this weekend, so it will pick this up