Oidc-client-js: 1.5.0-beta.3 ie11 error

[teamsmiley]

ie 11 got error so i downgrade to 1.4 ie works fine.
just idea.

[brockallen]

can you explain the errors you saw? any logs?

[teamsmiley]

chrome

ie11

this is what i got.

[brockallen]

I can't tell what the error is from the above screen shots. You will need to debug into it.

Also, if you clone the repo and run "npm run start" and browse to "http://localhost:5000/identityserver-sample.html" you should see the library working properly in IE, Edge, FF, and Chrome (all of which I just tested).

[teamsmiley]

i see

thanks. always

[ibrahimsen]

@teamsmiley How can you fixed this issue? I'm facing same issue in IE.

I'm using angular 6

[teamsmiley]

when i user oidc 1.5.1-beta-3, i get that error
so i change to 1.4.1 . it works fine now.

[teamsmiley]

"oidc-client": "^1.4.1",

[ibrahimsen]

@brockallen Is there any changelog for your versions? If I downgrade my version to 1.4.1 what features or fixing I will miss? Or will you plan to fix this issue?

[teamsmiley]

i think it's only happening with angular 6 .
so..i am not sure this is oidc-client error.

[ibrahimsen]

@teamsmiley I think It's about oidc-client because when I downgrade for 1.4.1 version it worked as expected.

[brockallen]

@ibrahimsen yes: https://github.com/IdentityModel/oidc-client-js/releases/tag/1.5.0

[asadsahi]

@brockallen having the same issue when running with IE 11 error in console:

Expected: ':'

downgrading to 1.4.1 works in same project.

Unable to see the real reason of error since webpack is bundling it and it all one line.

[ibrahimsen]

@brockallen I agree with you, I think oidc-client library should inspect this problem in angular 6.

[asadsahi]

Right I did some investigation and error seems to be somewhere Log.js perhaps:

I think webpack is evaling this module but when opening this module in the code, can't see any obvious error:

// Copyright (c) Brock Allen & Dominick Baier. All rights reserved.
// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
debugger;
let nopLogger = {
    debug(){},
    info(){},
    warn(){},
    error(){}
};

const NONE = 0;
const ERROR = 1;
const WARN = 2;
const INFO = 3;
const DEBUG = 4;

let logger;
let level;

export class Log {
    static get NONE() {return NONE};
    static get ERROR() {return ERROR};
    static get WARN() {return WARN};
    static get INFO() {return INFO};
    static get DEBUG() {return DEBUG};

    static reset(){
        level = INFO;
        logger = nopLogger;
    }

    static get level(){
        return level;
    }
    static set level(value){
        if (NONE <= value && value <= DEBUG){
            level = value;
        }
        else {
            throw new Error("Invalid log level");
        }
    }

    static get logger(){
        return logger;
    }
    static set logger(value){
        if (!value.debug && value.info) {
            // just to stay backwards compat. can remove in 2.0
            value.debug = value.info;
        }

        if (value.debug && value.info && value.warn && value.error){
            logger = value;
        }
        else {
            throw new Error("Invalid logger");
        }
    }

    static debug(...args){
        if (level >= DEBUG){
            logger.debug.apply(logger, Array.from(args));
        }
    }
    static info(...args){
        if (level >= INFO){
            logger.info.apply(logger, Array.from(args));
        }
    }
    static warn(...args){
        if (level >= WARN){
            logger.warn.apply(logger, Array.from(args));
        }
    }
    static error(...args){
        if (level >= ERROR){
            logger.error.apply(logger, Array.from(args));
        }
    }
}

Log.reset();

Can anyone spot any issues?

[benhysell]

I'm seeing the same exact issue in React and CRA...its pointing me to: Log.js line 5 from the IE debugger:

let nopLogger = {
    debug(){}, <---- IE. stops here
    info(){},
    warn(){},
    error(){}
};

This is with version 1.5.0.

[asadsahi]

@brockallen We really need to resolve this as this is the only library which is holding us to work with IE. Is it worth looking at? It can easily be reproduced in IE by running the any application with any oidc api usage.

[brockallen]

If you update to 1.5.1 the log error is solved due to the correct entry point being fixed in the module.

But I was able to see another error in IE11 using angualr. But in a vanilla JS project oidc-client works in IE11. So since you folks are the angular experts, can you help debug into and determine why angular is causing a problem with oidc-client?

[asadsahi]

Hi @brockallen thanks for responding and opening this issue. Apparently 1.5.1 has fix the error that I was having in angular cli project.

What problem are you having can you share some details, screenshot to have some guesses.

[brockallen]

@asadsahi di you have any problems anymore with 1.5.1?

[asadsahi]

I don't...Can I ask what was the fix in log.js which was breaking previously?

[brockallen]

I don't...Can I ask what was the fix in log.js which was breaking previously?

Nothing in the code. It had to do with oidc-client's package.json listing the ES6 module as the entry point rather than the compiled es5 version:

https://github.com/IdentityModel/oidc-client-js/commit/26e1fde61e414eb27797749b39bf9c22436879bf

[benhysell]

1.5.1 is also working for the React app I'm developing with CRA. I no longer receive the error with IE 11.

[brockallen]

Ok, I'll close this issue then, now that I have 2 people confirming that it's working. I suspect in my own sample I neglected to include babel-polyfill, which was probably my issue.