Oidc-client-js: bower, please :)

Created on 1 Jun 2016  路  5Comments  路  Source: IdentityModel/oidc-client-js

Great job with this. I've started working with it in an Angular 1.5 application, and so far it's been super easy to work with.

Would love to see this as a bower package though. Like a lot of devs, I try to limit the use of npm for just the tooling and node.js specific stuff, and use bower (or jspm or whatever) for the pure front-end application dependencies.

question

Most helpful comment

Yeah, there is a whole war over what js package managers you should use and all... I get it it.

I agree 100% that there should be an npm package, no doubt... and probably that should be the main one you promote.

But, there are tons of projects in the angular world using both npm and bower; the standard yo generator (generator-angular) even sets up with bower; as do many of microsoft's own stock new-project templates, etc.

So, I'd advocate that a bower package be available for those projects that do use it, while other people can stick to pure npm for all js management.

I personally have projects setup both ways, some use bower, some stick to pure npm... and I have yet to be able to get emotionally invested in either approach.

All 5 comments

I specifically removed my prior bower support because I got the exact opposite advice. npm is more than just for server-side JS. I'll let those with more experience hash this one out.

Yeah, there is a whole war over what js package managers you should use and all... I get it it.

I agree 100% that there should be an npm package, no doubt... and probably that should be the main one you promote.

But, there are tons of projects in the angular world using both npm and bower; the standard yo generator (generator-angular) even sets up with bower; as do many of microsoft's own stock new-project templates, etc.

So, I'd advocate that a bower package be available for those projects that do use it, while other people can stick to pure npm for all js management.

I personally have projects setup both ways, some use bower, some stick to pure npm... and I have yet to be able to get emotionally invested in either approach.

Ok, I concede. Can you 1) tell me how adding bower support will affect the dev workflow, and 2) send me a PR for it?

You already registered this in bower a while back, so adding back the bower.json should be all that's needed. There isn't a version property in the bower.json, so it will not affect the dev process... just keep tagging releases in github with semver tags and bower should automatically do its thing.

merged, thx

Was this page helpful?
0 / 5 - 0 ratings