Ohara: [Question] Could we skip check the build step for manager it tests?

Created on 18 Jun 2020  ·  12Comments  ·  Source: oharastream/ohara

See the following snapshot of QA console:

10:45:09 test10795
10:45:09 =========================================[PR:5254 is associated to version:0.11.0-SNAPSHOT]=========================================
10:45:09 =========================================[attach version label:v0.11.0]=========================================
+ 10:45:10 =========================================[check the build of PR:5254]=========================================
+ 10:55:40 =========================================[check the javadoc of PR:5254]=========================================
10:57:02 =========================================[check the scaladoc of PR:5254]=========================================
10:58:52 =========================================[check the makedoc of PR:5254]=========================================
10:59:09 test10795
10:59:10 =========================================[attach status for build]=========================================
10:59:35 test10795

The check the build step takes over 10 minutes, which seems not relevant to the manager-it script which only changes front-end code?

question

All 12 comments

/cc @oharastream/developer

We should build ohara-manager rather than whole project if the PR touches only frontend code?

We should build ohara-manager rather than whole project if the PR touches only frontend code?

That is exactly what I mean :)

如果只改前端的程式碼,後端沒改的話,就不要執行 check the build of PR: 的部份。

Sounds great.

就不要執行 check the build of PR: 的部份。

沒喔 還是要試著build ohara-manager,至於後端那些肥嫩嫩的scala code就可以跳過

不過另一個議題則是...為啥會build 10分鐘,也太久

沒喔 還是要試著build ohara-manager,至於後端那些肥嫩嫩的scala code就可以跳過

了解。

+1 for this idea 👍

目前在 oharastream ci 的 docker container 上執行 gradle clean build -x test -PskipManager 指令,需要花費約 7m 19s 的時間。

7m 19s 的時間。

我剛剛本地測試了一下也是差不多這個數字,前端約3分鐘,後端約4分鐘。

10分鐘可能是剛好太多QA、或是網路不太順

+1

Was this page helpful?
0 / 5 - 0 ratings