Ohara: [Manager] Errors encountered were not handled correctly when user create workspace

[vitojeng]

Describe the bug
Exception not handle properly.

To Reproduce
Steps to reproduce the behavior:

1. Use QuickstartVM 0.10.0-SNAPSHOT
2. Create workspace
   2.1. Step 1: name workspace1
   2.2. Step 2: Create a new node and add it
   2.3. Step 3: Submit, encounter an error
   2.4. Step 3: Submit, encounter an error
   2.5. Step 3: Submit, encounter an error
   2.6. Check developer tools, find three errors.
   2.7. Back to Step 1, and cannot move to Step 3

Expected behavior
User can retry to submit if encounter server side error.

Screenshots

• Create workspace
  
• Encounter three errors
  
• Response of error1
  
• Response error 2, error 3
  
• Cannot move to Step3
  

[saivirtue]

2.2. Step 2: Create a new node and add it
2.3. Step 3: Submit, encounter an error

Is the node expected valid? (i.e., the POST of /nodes return 200 and the node is Available)

[vitojeng]

yes. create node succeed.

[vitojeng]

想法討論:

1. create workspace 一定有可能遇到 server side error. 而 user 遇到 error 後, 一定會想做 retry submit. 因此若 create workspace 過程遇到任何 fail, 曾經建立過的物件可能都需要被清除. 讓使用者可以 retry.
2. 目前 create workspace 若遇到錯誤, 其訊息只會短暫停留, 使用者有可能會沒有看到. 這部份需要修改.

[saivirtue]

create workspace 一定有可能遇到 server side error. 而 user 遇到 error 後, 一定會想做 retry submit. 因此若 create workspace 過程遇到任何 fail, 曾經建立過的物件可能都需要被清除. 讓使用者可以 retry.

目前暫時解法可以重新刷新頁面(或回到home page)，從Settings的Delete workspace來刪除該未成功建立的workspace

[konekoya]

I'm not seeing this issue anymore. Has anyone run into this issue recently? If not, maybe we can consider closing this :)

[saivirtue]

create workspace 一定有可能遇到 server side error. 而 user 遇到 error 後, 一定會想做 retry submit. 因此若 create workspace 過程遇到任何 fail, 曾經建立過的物件可能都需要被清除. 讓使用者可以 retry.

Thanks for the works of @eechih in #5247, We could retry the failed step in workspace creation.

[vitojeng]

How about move to QA phase if you guys think that this bug should be resolved ?

[saivirtue]

How about move to QA phase if you guys think that this bug should be resolved ?

Sounds great!

[vitojeng]

QA passed. LGTM!
Thanks @oharastream/frontend !