Ohara: Flatten cluster settings to the first level

Created on 19 Dec 2019  ·  6Comments  ·  Source: oharastream/ohara

將物件的 settings 資料,攤平到物件的第一層,可以直接享受 Patch Update 的好處。
受影響的物件有 Zookeeper, Broker, Worker, Topic, Connector。

感謝 @chia7712


    • [x] flatter cluster settings and keep the deprecated "settings" (#3581) (@chia7712)


    • [x] remove "settings" from all json response (@chia7712) (#3647)


    • [x] [Manager] removing "settings" in all api tests (@saivirtue) (#3646)

    • ~[ ] [Manager] apply flatten settings to api and refactor cluster api functions (@saivirtue) (#3598)~

    This change will be applied to the following objects:


      • zookeeper


      • broker


      • worker


      • stream


      • topic


      • connector


      • workspace

    The basic supported APIs:

    1. get: fetch data & get from object api
    2. getAll: fetch data list & get from object api
    3. create: create data & save to object api
    4. update: update data
    5. stage: update object api
    6. delete: delete data & object api
    7. start: start service
    8. stop: stop service

    Response data:

    {
     "settings": {
     },
     "stagingSettings":{
     },
     "settingDefinitions":[
     ],
     "other_runtime_fields"
    }
    




v0.9.0

Most helpful comment

@oharastream/frontend I fail to catch the progress of removing the "settings". Is it a good time to remove the "settings"?

Ongoing. Will fire a PR in late today.

All 6 comments

@eechih great idea :)

@oharastream/frontend
Please see the description of sub-task 3 for the conclusion.
Let me know if I was misunderstanding something :)

@oharastream/frontend I fail to catch the progress of removing the "settings". Is it a good time to remove the "settings"?

@oharastream/frontend I fail to catch the progress of removing the "settings". Is it a good time to remove the "settings"?

Ongoing. Will fire a PR in late today.

ping @chia7712
Front-end is ready to accept no settings world, you can remove it :)

all tasks are completed :)

Was this page helpful?
0 / 5 - 0 ratings