Ohara: ping Ohara Manager committers if PR breaks the APIs compatibility

Created on 2 Jul 2019  ·  9Comments  ·  Source: oharastream/ohara

the manager-api test alerts us to notice the broken Restful APIs compatibility caused by PR. In order to have correct fix to UI code, jenkins should ping the suitable committers to check the APIs code for Ohara Manager.

Most helpful comment

https://github.com/oharastream/ohara/pull/1699#issuecomment-507960814

效果大概如上,麻煩大家看一下

All 9 comments

@vitojeng @jackyoh @saivirtue @eechih @konekoya @wu87988622 Any suggestions?

我預期會讓jenkins自動在commect上貼上相關人員的名字,藉此提醒相關人員

貼上相關人員的名字

+1

如何決定相關的人?

我預期會讓jenkins自動在commect上貼上相關人員的名字,藉此提醒相關人員

+1 Sounds good to me :)

如何決定相關的人?

現在來徵選 想被貼的請舉手

現在來徵選 想被貼的請舉手

XXD 🙋‍♂🙋‍♂🙋‍♂🙋‍♂🙋‍♂🙋‍♂🙋‍♂

如何決定相關的人?

現在來徵選 想被貼的請舉手
@konekoya 舉手,我做👨‍💻....

https://github.com/oharastream/ohara/pull/1699#issuecomment-507960814

效果大概如上,麻煩大家看一下

Works perfectly for me. I think you can close this issue now @chia7712

Was this page helpful?
0 / 5 - 0 ratings