Office-js-docs-pr: Document links to a non-existing .json file in its note

Created on 10 Jun 2019  Â·  3Comments  Â·  Source: OfficeDev/office-js-docs-pr

The document specifies:

A complete sample JSON file is available in the OfficeDev/Excel-Custom-Functions GitHub repository.

However it links to a non-existing .json file:
https://github.com/OfficeDev/Excel-Custom-Functions/blob/master/src/functions/functions.json


Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Excel doc bug

Most helpful comment

@kbrandl oh right! Yes, sure thing. :) Thanks for pointing this out, @PeterBrodersen. We have switched up the yo office template a couple times, so this is an out of date link. I'll go ahead and update it.

All 3 comments

@PeterBrodersen thanks for reporting this issue; we'll look into it and update doc as needed.

@mscharlock can you please look into this issue when you have a chance? Looks like the functions.json file is no longer included in the sample project (OfficeDev/Excel-Custom-Functions), presumably since it's being autogenerated from the JSDoc comments. Thanks!

@kbrandl oh right! Yes, sure thing. :) Thanks for pointing this out, @PeterBrodersen. We have switched up the yo office template a couple times, so this is an out of date link. I'll go ahead and update it.

@PeterBrodersen a fix is in the docs and should go out tomorrow when we do our latest pull in of all our updates. Thank you for reporting this and hope you are enjoying developing with custom functions! I'm going to close this issue but let me know if you would like me to reopen this issue by commenting on it. Thank you again!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

chucklay picture chucklay  Â·  7Comments

PramodKumarYadav picture PramodKumarYadav  Â·  3Comments

thunter05 picture thunter05  Â·  6Comments

redcirkle picture redcirkle  Â·  3Comments

Alex-Mann picture Alex-Mann  Â·  6Comments