Odo: Clean up context in devfile integration tests

[maysunfaisal]

Currently most of the devfile integration tests that use context flag --context, change to the context directory in BeforeEach even though we're using the full path in --context

Ideally, we should not switch to the context directory when using --context. Clean up all devfile integration tests for the flag.

/area devfile
/kind cleanup

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dharmit]

Doesn't look like we addressed this. Reopining the issue.

[dharmit]

/good-first-issue

[openshift-ci-robot]

@dharmit:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[valaparthvi]

I would like to work on this.
/assign valaparthvi

[openshift-ci-robot]

@valaparthvi: GitHub didn't allow me to assign the following users: me.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

I would like to work on this.
/assign me

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[valaparthvi]

/assign valaparthvi

[valaparthvi]

Currently the following devfile integration tests need this cleanup -

tests/integration/devfile/cmd_devfile_debug_test.go
tests/integration/devfile/cmd_devfile_delete_test.go
tests/integration/devfile/cmd_devfile_describe_test.go
tests/integration/devfile/cmd_devfile_log_test.go
tests/integration/devfile/cmd_devfile_push_test.go
tests/integration/devfile/cmd_devfile_test_test.go
tests/integration/devfile/cmd_devfile_url_test.go
tests/integration/devfile/cmd_devfile_watch_test.go

[valaparthvi]

Scope of this issue for sprint 199 -

• [x] 1. Fix the tests mentioned in https://github.com/openshift/odo/issues/3801#issuecomment-779113525. Some of the tests are a quick fix, some might require a little more work.
• [x] 2. Identify any other tests that might need cleanup.

_Might be a 3-day task._

[valaparthvi]

How do we want to go about this? Do we want to remove the --context flag wherever it is not used to test the context or remove the Chdir in BeforeEach and modify all tests to work with the changes? I am not sure if doing either affects the test coverage.

@dharmit @girishramnani @mik-dass thoughts?

[mik-dass]

How do we want to go about this? Do we want to remove the --context flag wherever it is not used to test the context or remove the Chdir in BeforeEach and modify all tests to work with the changes? I am not sure if doing either affects the test coverage.

We should remove the Chdir in BeforeEach wherever possible as that would help us figure out if the context flag works for the command properly or not.