Odo: test-cmd-devfile-log teardown steps throws error while accessing projectDir on windows platform

Created on 10 Jul 2020  路  12Comments  路  Source: openshift/odo

/kind bug

What versions of software are you using?

Operating System:
Win10

Output of odo version:
master

How did you run odo exactly?

Run make test-cmd-devfile-log on windows

Actual behavior

> make test-cmd-devfile-log
Running Suite: Devfile Suite
============================
Random Seed: 1594377900
Will run 1 of 95 specs

SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSCreated dir: C:\Users\Admin\AppData\Local\Temp\203208851
Running odo.exe with args [odo preference set Experimental true]
[odo] Global preference was successfully updated
Setting KUBECONFIG=C:\Users\Admin\AppData\Local\Temp\203208851\config
Creating a new project: ebxzlgtift
Running odo.exe with args [odo project create ebxzlgtift -w -v4]
[odo]  -  Waiting for project to come up  ...
[odo] I0710 10:45:13.247354   10808 occlient.go:542] Status of creation of project ebxzlgtift is Active
[odo] I0710 10:45:13.301183   10808 occlient.go:547] Project ebxzlgtift now exists
[odo] I0710 10:45:13.303540   10808 occlient.go:582] Status of creation of service account &ServiceAccount{ObjectMeta:{default  ebxzlgtift /api/v1/namespaces/ebxzlgtift/serviceaccounts/default a31009da-c299-11ea-a594-fa163e9b6334 19441694 0 2020-07-10 10:39:30 +0000 GMT <nil> <nil> map[] map[] [] []  []},Secrets:[]ObjectReference{ObjectReference{Kind:,Namespace:,Name:default-token-qr8sk,UID:,APIVersion:,ResourceVersion:,FieldPath:,},ObjectReference{Kind:,Namespace:,Name:default-dockercfg-jj7xv,UID:,APIVersion:,ResourceVersion:,FieldPath:,},},ImagePullSecrets:[]LocalObjectReference{LocalObjectReference{Name:default-dockercfg-jj7xv,},},AutomountServiceAccountToken:nil,} is ready
 V  Waiting for project to come up [998ms]
[odo]  V  Project 'ebxzlgtift' is ready for use
[odo]  V  New project created and now using project: ebxzlgtift
[odo] I0710 10:45:13.331457   10808 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
Current working dir: C:\Users\Admin\go\src\github.com\openshift\odo\tests\integration\devfile
Setting current dir to: C:\Users\Admin\AppData\Local\Temp\203208851
Setting current dir to: C:\Users\Admin\AppData\Local\Temp\203208851/projectDir
Running odo.exe with args [odo create nodejs --project ebxzlgtift fjkkqn]
[odo] Experimental mode is enabled, use at your own risk
[odo]
[odo] Validation
 V  Checking devfile existence [0ns]
 V  Checking devfile compatibility [337900ns]
 V  Creating a devfile component from registry: DefaultDevfileRegistry [337900ns]
 V  Validating devfile component [1ms]
[odo]
[odo] Please use `odo push` command to create the component with source deployed
Running odo.exe with args [odo push --project ebxzlgtift]
[odo]
[odo] Validation
 V  Validating the devfile [0ns]
[odo]
[odo] Creating Kubernetes resources for component fjkkqn
 V  Waiting for component to start [6s]
[odo]
[odo] Applying URL changes
[odo]  V  URLs are synced with the cluster, no changes are required.
[odo]
[odo] Syncing to component fjkkqn
 V  Checking files for pushing [19ms]
 V  Syncing files to the component [213ms]
[odo]
[odo] Executing devfile commands for component fjkkqn
 V  Executing install command "npm install" [2s]
 V  Executing run command "npm start" [1s]
[odo]
[odo] Pushing devfile component fjkkqn
[odo]  V  Changes successfully pushed to component
Running odo.exe with args [odo log]
[odo] time="2020-07-10T10:40:02Z" level=info msg="create process:devrun"
[odo] time="2020-07-10T10:40:02Z" level=info msg="create process:debugrun"
[odo] time="2020-07-10T10:40:05Z" level=debug msg="no auth required"
[odo] time="2020-07-10T10:40:05Z" level=info msg="stop the program" program=debugrun
[odo] time="2020-07-10T10:40:05Z" level=info msg="stop the program" program=devrun
[odo] time="2020-07-10T10:40:05Z" level=info msg="force to kill the program" program=debugrun
[odo] time="2020-07-10T10:40:05Z" level=info msg="force to kill the program" program=devrun
[odo] time="2020-07-10T10:40:05Z" level=debug msg="no auth required"
[odo] time="2020-07-10T10:40:05Z" level=debug msg="succeed to find process:devrun"
[odo] time="2020-07-10T10:40:05Z" level=info msg="try to start program" program=devrun
[odo] time="2020-07-10T10:40:05Z" level=info msg="success to start program" program=devrun
[odo] ODO_COMMAND_RUN is npm start
[odo] Changing directory to ${CHE_PROJECTS_ROOT}/nodejs-starter
[odo] Executing command cd ${CHE_PROJECTS_ROOT}/nodejs-starter && npm start
[odo] > [email protected] start /projects/nodejs-starter
[odo] > node server.js
[odo] App started on PORT 3000
[odo] time="2020-07-10T10:40:06Z" level=debug msg="wait program exit" program=devrun
Running odo.exe with args [odo log -f]
[odo] time="2020-07-10T10:40:06Z" level=debug msg="wait program exit" program=devrun
Deleting project: ebxzlgtift
Running odo.exe with args [odo project delete ebxzlgtift -f]
[odo]  V  Deleted project : ebxzlgtift
[odo]  !  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project 
may still exist on a different node.
Setting current dir to: C:\Users\Admin\go\src\github.com\openshift\odo\tests\integration\devfile
Deleting dir: C:\Users\Admin\AppData\Local\Temp\203208851

------------------------------
+ Failure in Spec Teardown (AfterEach) [13.654 seconds]
odo devfile log command tests
C:/Users/Admin/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_log_test.go:14
  Verify odo log for devfile works [AfterEach]
  C:/Users/Admin/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_log_test.go:49
    should log run command output
    C:/Users/Admin/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_log_test.go:55

    Unexpected error:
        <*os.PathError | 0xc000074270>: {
            Op: "remove",
            Path: "C:\\Users\\Admin\\AppData\\Local\\Temp\\203208851\\projectDir",
            Err: 0x20,
        }
        remove C:\Users\Admin\AppData\Local\Temp\203208851\projectDir: The process cannot access the file because it is being used by another process.
    occurred

    C:/Users/Admin/go/src/github.com/openshift/odo/tests/helper/helper_filesystem.go:28
SSSSSSSSSSSSSSS

Summarizing 1 Failure:

[Fail] odo devfile log command tests [AfterEach] Verify odo log for devfile works should log run command output 
C:/Users/Admin/go/src/github.com/openshift/odo/tests/helper/helper_filesystem.go:28

Expected behavior

We should handle the C:\Users\Admin\AppData\Local\Temp\203208851\projectDir smartly in the spec. As it is expected behaviour on windows.

Any logs, error output, etc?

areWindows aredevfile aretesting kinfailing-test

All 12 comments

/kind test
/area windows

This is not important for v2 as its tests related.

/assign anandrkskd

@girishramnani: GitHub didn't allow me to assign the following users: anandrkskd.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign anandrkskd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anandrkskd FYI this may be fixed by this code in PR #3586:
https://github.com/openshift/odo/blob/4454101bff1adb11e91ca810d0714f86e592fa91/tests/helper/helper_filesystem.go#L27

(Watch had the same problem on Windows, and this PR includes the above fix for that)

@anandrkskd Can you please verify the change on windows. If it works.

Yes, I have checked the changes in PR #3586 and got to know this will fix this issue also.

@jgwest Can you please add this issue also as a fix in pr #3586

Yes, I have checked the changes in PR #3586 and got to know this will fix this issue also.
/close

@amitkrout: Closing this issue.

In response to this:

Yes, I have checked the changes in PR #3586 and got to know this will fix this issue also.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

PR #3586 is not yet merged

/unassign @anandrkskd

Was this page helpful?
0 / 5 - 0 ratings