Odo: Code seems to do something different than what's commented

[dharmit]

/kind bug

Code comment at: https://github.com/openshift/odo/blob/00262d842955b1d5d9d1f6461b8e5ef41393b7e1/pkg/component/component.go#L891-L900
talks about extracting labels but it doesn't look like the block following it is actually extracting them.

[kadel]

/remove-kind bug
/kind code-refactoring

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[dharmit]

Also found repetition of code: https://github.com/openshift/odo/blob/585fd6dc5cd96f536960f0de6664cb66e09cefa5/pkg/component/component.go#L888-L918

Still relevant and good first issue to get hands dirty with odo code base, IMO.

/remove-lifecycle stale

[niconosenzo]

@dharmit I would like to have some fun working on it :).

[mik-dass]

@dharmit I would like to have some fun working on it :).

Done 👍