Octoprint: [1.3.10] SVG Favicon doesn't show in Firefox
Problem
Firefox doesn't show the new SVG Favicon:
According to this comment and this link this seems to be due to the used mime type. Doesn't seem to be the mime type, that's already set to image/svg+xml.
foosel
All 4 comments
Correct mime type is already set, favicon still doesn't show up. Investigating...
foosel
on 8 Nov 2018
Fixed by the above commit. The issue was actually that drawing a SVG to a canvas used internally fails silently in Firefox if the SVG doesn't have width and height attributes. Simply adding those solved the issue immediately.
Pushed and ready for 1.3.10rc2
foosel
on 8 Nov 2018
👍3
Thank you!
ThaliaFP
on 9 Nov 2018
❤1
1.3.10rc2 was just released.
foosel
on 13 Nov 2018
Was this page helpful?
0 / 5 - 0 ratings
Related issues
mdelecate
路
5Comments
christianh17
路
5Comments
foosel
路
5Comments
mc2880
路
4Comments
ModischFabrications
路
3Comments
Most helpful comment
Fixed by the above commit. The issue was actually that drawing a SVG to a canvas used internally fails silently in Firefox if the SVG doesn't have width and height attributes. Simply adding those solved the issue immediately.
Pushed and ready for 1.3.10rc2