October: Repeater dropdowns and triggering loading indicator

Created on 13 Oct 2020  路  5Comments  路  Source: octobercms/october

This bug manifests itself when using dependsOn inside form repeater.
Changing of value in dropdown fires loading indicators not only in his own dependents.
loading

Bug

Most helpful comment

@bennothommo This bug does not affect data entry. This bug affects performance side of repeater form entering. If you change one dropdown, that has some dependant, all dependant's requests are triggered. If you have 10 items in repeater, one change of one repeater's field triggers 10 requests, but 9 of them are needless.

All 5 comments

Same here v.1.0.471

@Rike-cz does this bug actually create problems with form entry? For example, if you select another item in the dropdown (perhaps the second item) and then dependsOn refreshes it, does it reset the dropdown to the first item? It'll be a more critical bug if it's affecting data entry.

@bennothommo This bug does not affect data entry. This bug affects performance side of repeater form entering. If you change one dropdown, that has some dependant, all dependant's requests are triggered. If you have 10 items in repeater, one change of one repeater's field triggers 10 requests, but 9 of them are needless.

@Rike-cz would you mind giving the fix in #5421 a try and let me know if that works better?

@bennothommo You are great, Ben, you killed that bug absolutely! Thanks a lot!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

m49n picture m49n  路  3Comments

EbashuOnHolidays picture EbashuOnHolidays  路  3Comments

atrauzzi picture atrauzzi  路  3Comments

mittultechnobrave picture mittultechnobrave  路  3Comments

mittultechnobrave picture mittultechnobrave  路  3Comments