October: Repeater item and parents dependsOn issue

[SebastiaanKloos]

• OctoberCMS Build: 468
• PHP Version: 7.2

Description:

While depending on repeater field from a field within the repeater fields, the js crashes when deleting a repeater item.

step_fields:
    label: 'Vragen'
            type: repeater
            span: full
            form:
                fields:
                    question_trigger:
                        label: 'Toon vraag als'
                        type: dropdown
                        placeholder: 'Selecteer vraag'
                        span: storm
                        cssClass: col-sm-6
                        dependsOn: step_fields
                        trigger:
                            action: show
                            field: question_use_trigger
                            condition: checked

Produces this error when trying to delete a repeater:

Fix

Flipping these two lines fixes the issue:

• https://github.com/octobercms/october/blob/0eac1290031224b68e82be4104a574f3f5ee107c/modules/backend/formwidgets/repeater/assets/js/repeater.js#L134

• https://github.com/octobercms/october/blob/0eac1290031224b68e82be4104a574f3f5ee107c/modules/backend/formwidgets/repeater/assets/js/repeater.js#L135

I was wondering why the change event is called before the item is deleted. Is there something expecting this event before deleting the item?

If not, then I would like to suggest flipping these lines. If needed, I can provide a PR.

Steps To Reproduce:

See above

[LukeTowers]

@SebastiaanKloos there is a problem doing it the other way around: https://github.com/octobercms/october/pull/4736#discussion_r400566131

[SebastiaanKloos]

@LukeTowers Totally missed your comment. I'll check it tomorrow. Thank you for your reply!

[SebastiaanKloos]

@SebastiaanKloos there is a problem doing it the other way around: https://github.com/octobercms/october/pull/4736#discussion_r400566131

Ahh gotcha. I'll debug it a bit more tomorrow

[github-actions[bot]]

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.