October: Laravel 6: Email validation filter is too permissive

Created on 12 May 2020  路  3Comments  路  Source: octobercms/october

Originally reported by @datune.

Laravel introduced fancier email validation in 5.8 (https://github.com/laravel/framework/pull/26503), but made it too permissive by default, supposedly following the RFC exactly (although there are inconsistencies reported). This has caused breaking changes in emails reported as valid even though they may not be: https://github.com/laravel/framework/issues/28233, https://github.com/laravel/framework/issues/27875.

We need to make sure that October overrides Laravel's email validator to make the default filter used email:filter, which uses PHP's built in email validator, instead of email:rfc which isn't even technically accurate to the RFC (reportedly).

We should still support the other filters used, we just need to change the default filter used: https://laravel.com/docs/6.x/validation#rule-email.

High Completed Bug

All 3 comments

@bennothommo could you take a stab at this?

Will do!

Was this page helpful?
0 / 5 - 0 ratings