October: 'Required' validation doesn't work correctly on relation fields

[Flynsarmy]

Say _Post_ belongs to many _Categories_. If I put

public $belongsToMany = [
    'categories' => ['My\Plugin\Models\Category', 'table' => 'my_plugin_posts_categories', 'order' => 'name']
];

public $rules = [
    'categories' => 'required'
];

into my Post model and hit save on a record that doesn't already have categories - even if I have a category selected in the form it will error with a message about categories being required.

Some things to note:

• If the record already has categories attached to it, so long as you leave at least one selected the form will save successfully
• If you have no categories selected, the form will error as expected
• If you have categories selected, the form will still error if your record in the DB doesn't already have categories attached to it.

I've whipped up a demo repo complete with instructions to replicate here.

[daftspunk]

Can you retest using the latest build? There has been some work performed to the validation of related fields lately.

[Flynsarmy]

This is not fixed. The instructions on the git repo posted in my issue above still replicate the issue.

[pomek]

+1 / the same problem.

[Albert221]

:+1: same here

[Comandeer]

+1

[Sobak]

+1, it would be nice to have it fixed

[michieldewilde]

+1, got the same issue.

[jovib]

+1

[cybear-d]

i've also got the same issue.

after some debugging, i found that in October\Rain\Database\Traits\Validation, line 138 is not getting the related model value, it returning empty array.

...
$data[$attribute] = $this->getRelationValue($attribute);

i don't know if this related to laravel itself or not.

for now i change the above snippet to,

...
$data[$attribute] = $this->getAttribute($attribute)->lists('id');

hope this will help you find out what the bug is.

[mohammadmojrian]

+1

[seanthepottingshed]

Any progress on this issue?

[iboved]

+1

[deckymcdonough]

+1

[nozreh]

+1 this is kinda problematic especially on pivot data for extending a plugin.

[pomek]

I've never seen more ignorant people than here... I abandoned this "CMS". I suggest the same thing to you.

[daftspunk]

If you lack the ability to read the documentation or understand the concept of open source. You should probably abandon programming too.

For the rest of you, this can be overcome by simply using the beforeValidate method in your model, or the formBeforeSave method in the controller. All issues are important to us, we are working as hard as we can. Thank you for your patience.

Also consider submitting a bounty on issues that require escalation.

[pomek]

[removed nonconstructive comment]

[daftspunk]

The squeaky wheel gets the grease, I suppose.

[daftspunk]

This issue is now resolved.

• Functional tests: https://github.com/daftspunk/oc-test-plugin/commit/77571477e8df7546b5abe5fd166e25a593e6f05f
• Unit tests: https://github.com/octobercms/october/commit/b268f54189e2233211259f3b182e3009c0bc7599
• Code changes: https://github.com/octobercms/library/commit/58f1b1c6ab741d45b17aa63589aff81cf572948c
• Time taken for this work: 2 hours and 28 minutes
• Estimated wholesale cost: ~USD $400

Please don't be rude. We do this for love.