October: RelationController manage filters throws error when the search inside the popover is used

[kOld]

• OctoberCMS Build: 459
• PHP Version: 7.2.23
• Database Engine: MySQL
• Plugins Installed: Rainlab.Users

Description:

RelationController manage filters throws the following error when the search inside the popover is used:
"A widget with class name 'relationCommentsManageFilter' has not been bound to the controller" on line 597 of /var/www/modules/backend/Classes/Controller.php

Steps To Reproduce:

• Install my test plugin: https://github.com/kOld/test-plugin
• Navigate to Playground -> Posts -> New Post
• In the first tab "Comments", click Add Comment
• Click on "Users: All"
• Type something in the filter

Possible correction:

https://github.com/kOld/october/commit/76b776848cd95a848eec57325d49176bd95cdfee

This seams to happen because the data-request-data="" parameter is lost when the popover is created inside the modal, creating the popover inside the div that has the data-request-data="" seems to fix the issue

[LukeTowers]

@kOld can you submit your test plugin changes as a PR to the test plugin and your fix as a PR to this repo (the develop branch).

[kOld]

Sure, I will do it later today. Just found that on this PR they encountered the same issue: https://github.com/octobercms/october/pull/4373#issuecomment-500104040

[github-actions[bot]]

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days.

• If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. - If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[github-actions[bot]]

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days.

• If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. - If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[github-actions[bot]]

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[LukeTowers]

@bennothommo are you able to look into this?

[bennothommo]

Fixed by https://github.com/octobercms/october/commit/9155e7de7e1035dc3d6bd51288f909268c240a76.