October: AJAX request errors not reported correctly when in maintenance mode

[nathan-van-der-werf]

• OctoberCMS Build: 1.0.457
• PHP Version: 7.3.7
• Database Engine: Not relevant
• Plugins Installed: Not relevant

Description:

When firing AJAX requests when the OctoberCMS application is in maintenance mode you will not get a "good error", see screenshot for a backend example:

Steps To Reproduce:

1) Put OctoberCMS in maintenance mode
2) Try to fire an AJAX request (without refreshing the webpage before you do this)
3) You'll see an "ugly" error

The issue is not only in the backend, it's also in the frontend.

Possible solution

The middleware responsible for doing this is:
vendor/october/rain/src/Foundation/Http/Middleware/CheckForMaintenanceMode.php.

It's loaded from the kernel:
vendor/october/rain/src/Foundation/Http/Kernel.php:30

The middleware will need an additional check for AJAX requests, we could put some code in the catch clause like:

if ($request->ajax()) {
    throw new SomeExceptionWhichGetsRenderedBetter('A better message');
}

Another good feature would be the possibility to disable or override the middleware, the only way to do this at the moment is by creating your own kernel.php and registering it in the bootstrap/app.php.

[w20k]

@nathan-van-der-werf thanks for reporting! I've seen it already :)

[Samuell1]

Ajax should be allowed on Maintenance mode. Like it was disscussed here: https://github.com/octobercms/october/issues/4258

Or this is that maintenance mode that puts down everything?

[nathan-van-der-werf]

Ajax should be allowed on Maintenance mode. Like it was disscussed here: #4258

Or this is that maintenance mode that puts down everything?

It's the php artisan down (so the one putting the application / website "offline")

[github-actions[bot]]

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days. If this issue is still relevant or you would like to see action on it, please respond and we will get the ball rolling.

[LukeTowers]

@nathan-van-der-werf an ApplicationException gets handled nicely by the backend, you could give that a try and make a PR