October: Visual glitches while navigating backend forms with keyboard

[Eoler]

• OctoberCMS Build: 457
• PHP Version: 7.2

Description:

Fantastic work for keyboard users in #4454 but there are visual glitches in certain form widgets:

• switch
• record finder

Steps To Reproduce:

Just tab around the form with switches and record finder:

[LukeTowers]

@ayumihamsaki could you look at this and make a PR that we could include in 458? @Eoler or perhaps you could make a PR to fix it?

[ghost]

@Eoler @LukeTowers

Will investigate this further.

I understand the 'switch' issue, but what do you mean by 'record finder'

[LukeTowers]

@ayumihamsaki it's the bottom two fields, selecting them makes them expand vertically and moves the popup triggering button from the right to the left

[ghost]

Anyway fixed, see results:

[daftspunk]

I have been unable to replicate this in the latest develop branch. I regret to inform that a lot of these changes were poorly implemented and had to be rolled back. The contributor of these features will need to make another attempt, perhaps in a more organised fashion where it is possible to review each enhancement independently or propose the changes incrementally

[Eoler]

I have been unable to replicate this in the latest develop branch.

It was reverted in: https://github.com/octobercms/october/commit/199407f1a05da2bf4f1f7df8bb03b92cde34bd89

I regret to inform that a lot of these changes were poorly implemented and had to be rolled back. The contributor of these features will need to make another attempt, perhaps in a more organised fashion where it is possible to review each enhancement independently or propose the changes incrementally

Changes were mostly working but repositories/author(s) misteriously vanished.
I have one forked OctoberCMS installation where customer manages ~300K records and backend keyboard entry is critical for their success. Guess I'll try to reimplement it with a plugin + form behavior, already handling focusing first form field with injected JS...

[LukeTowers]

@Eoler @ayumi-cloud we're open to having those enhancements in core, we had to revert them because they weren't stable enough for 458. I'd love to see them resubmitted so that we can get it added into a future build after some more in depth testing.