October: Mailgun driver support EU region

[Wachem]

Expected behavior

Chose your region in the mail (Mailgun) setup (US/EU).

Actual behavior

October only calls the US API endpoint instead of the (new) EU API endpoint.

Reproduce steps

Use a Mailgun domain in EU region with following API endpoint: https://api.eu.mailgun.net/v3/*

October build

443

[LukeTowers]

@Wachem feel free to make a PR to add support for this.

[Wachem]

@Wachem feel free to make a PR to add support for this.

I'll look into this soon ;-)

[CptMeatball]

Where's the file located that calls the API? Inside the core or in october.drivers?

[LukeTowers]

It lives in Laravel, so it would need to be done in October/Rain. See https://github.com/laravel/framework/issues/25410, and https://github.com/laravel/framework/pull/24994, https://github.com/laravel/framework/commit/8544966587e77838f542f7ab0c405371c996b7b0, & finally https://github.com/laravel/framework/pull/25010 all documented by https://github.com/laravel/docs/pull/4706 to get an idea of how to implement this in October.

[Wankishh]

In services.php mailgun just add new entry endpoint => api.eu.mailgun.net

[LukeTowers]

@Wankishh that won't work because October uses Laravel 5.5 so the changes I linked are not present in the version of Laravel that we use.

[DieterHolvoet]

Any update on this issue? Is the only solution to update laravel/framework, or is there any OctoberCMS specific development to be done?

[DieterHolvoet]

Looks like they decided to backport this feature to 5.5 (https://github.com/laravel/framework/issues/26576), I can confirm this is working correctly using v5.5.45 of laravel/framework.

[LukeTowers]

@DieterHolvoet could you submit a PR to the config to document how to enable EU region? Leave it set to the default north america region though.

[w20k]

@LukeTowers endpoint was added as a third parameter, so you could change URL if needed.

[LukeTowers]

Great, just want an example added to the config file so people don't get confused. Basically exactly like https://github.com/laravel/laravel/blob/master/config/services.php#L20 but perhaps with a link to the endpoint docs. Also, that key will need to be added to the october:env command.

[w20k]

@LukeTowers sure thing, will do it tomorrow, or today ;)

[w20k]

What do you think @LukeTowers if october:env will generate additional env values, based on the MAIL_DRIVER selected?
Example:
If MAIL_DRIVER == mailgun, then add 'MAILGUN_DOMAIN', 'MAILGUN_SECRET', 'MAILGUN_ENDPOINT'

[LukeTowers]

@w20k I think you can just always include those regardless of driver selected.

[github-actions[bot]]

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days. If this issue is still relevant or you would like to see action on it, please respond and we will get the ball rolling.

[LukeTowers]

Completed in https://github.com/octobercms/october/commit/64d02b77cc973aab437ef70c822527e404b2d224

[Tetraneon]

Hi !
Documentation should be updated : https://octobercms.com/docs/services/mail where :

'mailgun' => [
    'domain' => 'your-mailgun-domain',
    'secret' => 'your-mailgun-key',
],

would be :

'mailgun' => [
    'domain' => '',
    'secret' => '',
    'endpoint' => 'api.mailgun.net', // api.eu.mailgun.net for EU
],

[bennothommo]

@Tetraneon Please feel free to submit a PR to the docs repository.

[Tetraneon]

@bennothommo 👍 You're right ! I learn everyday !
It has just been done !

[bennothommo]

Nice one @Tetraneon!