October: Trigger filterfields on adding/removing repeater field

Created on 15 Jun 2018  路  10Comments  路  Source: octobercms/october

Expected behavior

When an item gets added/removed from a repeater, it should trigger the 'filterFields' function of the parent model.

Actual behavior

It doesn't trigger 'filterFields' on adding/removing an item.

Reproduce steps
  1. Create a model with a repeater and text field inside:
        items:
            label: 'Repeater'
            type: repeater
            form:
                fields:
                    test:
                        label: 'When removing this entry'
        some_other:
            label: 'This should update'
            dependsOn: [items]
  1. Add an item to the repeater.
  2. Remove the item from the repeater
October build

436

Completed Bug

All 10 comments

I don't have time to look into this right now but feel free to update the issue with any more information on why this is happening.

Actually there is nothing happening when removing or adding a repeater item. I will submit a pull request if I can fix it myself.

Closing as it has been over a month since any activity on this occurred and we are trying to figure out what issues are still relevant. If this is still something that you would like to see through to fruition please respond and we can get the ball rolling.

@bennothommo Could you re-open this issue as I would like to create a PR for this. I found out there is no event triggered when adding or removing an item. I tried adding events but the repeater widget causes some small issues because it is nested. I hope I'll be able to fix this. I'll try to create a PR very soon

This definitely needs some more work

CleanShot 2019-11-04 at 00 32 06

Go for it, @SebastiaanKloos :)

@bennothommo thanks! :)

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days. If this issue is still relevant or you would like to see action on it, please respond and we will get the ball rolling.

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days.

  • If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. - If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days.

  • If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. - If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.
Was this page helpful?
0 / 5 - 0 ratings