October: orderBy() clause ignored

[tiipiik]

Expected behavior

Use of orderBy() clause in queries to order models

Actual behavior

orderBy() has no effect

Reproduce steps

Use orderBy() in query and add different kind of orders, list returned is always the same. You can use the Random filter you will see that always the same list is returned.

First I was thinking of an error of mine as I was using it in a new plugin, but I've seem the same exact problem on a running website where I only want to change an orderBy() clause.

October build

419

[daftspunk]

Looks to be working fine over here.

Db::table('users')->orderBy('name')->get();

[tiipiik]

Yes it works if you use DB::table(), but not if you use a model, like MyModel::orderBy('name')->get();

[daftspunk]

Again. Fine over here:

RainLab\User\Models\User::orderBy('name')->get();

This issue lacks enough detail or the replication instructions cannot be actioned easily. As per the contribution guidelines, please provide the exact steps you are taking for the issue to occur. This will be used for peer review.

Here is an example of a bug summary:

The CMS page URL is not being set automatically from the title value.

Here is an example of some reproduce steps:

1. In the back-end, open the CMS > Pages section
2. Click the "Add" button
3. Enter [Hello] for the Title field
4. Click the Save button

Here is an example of expected behavior:

• The Title should be set to [Hello]
• The URL should be set to [/hello]

Here is an example of actual behavior:

• The Title is set to [Hello] correctly
• The URL is left empty

[tiipiik]

I've tested with your code and it works.

Tested again with mine and still not ordering, like if orderBy() was ignored.

use \Tiipiik\Partners\Models\Partner;

function onStart() {
    $this['partners'] = Partner::orderBy('name', 'desc')->get();
}

Maybe I missed something in the models but don't see what. I have the same problem on my Catalog plugin where I can't order products for example.

[jan-vince]

Try to use trace_sql() to find how SQL queries are built.

Maybe you are using NestedTree trait?

[daftspunk]

Please give us the full picture, we are doing blind guesswork. Paste your model class.

[tiipiik]

@jan-vince yes I use NestedTrait, but only in the Partners model, not in the Product one.

Here is the full model class

<?php namespace Tiipiik\Partners\Models;

    use Model;

    class Partner extends Model
    {
        use \October\Rain\Database\Traits\NestedTree;

        public $table = 'tiipiik_partners_partners';

        public $rules = [
            'name' => 'required|unique:tiipiik_partners_partners',
            'slug' => 'required',
        ];

        public static $allowedSortingOptions = array(
            'name asc' => 'Nom (ascendant)',
            'name desc' => 'Nom (descendant)',
            'random' => 'Aléatoire',
            'sort_order asc' => 'Ordonné (ascendant)',
            'sort_order desc' => 'Ordonné (descendant)',
        );

        protected $guarded = ['*'];
        protected $fillable = ['name', 'slug', 'description'];

        public $attachOne = [
            'cover' => ['System\Models\File', 'delete' => true]
        ];
    }

[daftspunk]

use \October\Rain\Database\Traits\NestedTree;

Nested sets belongs to a strict structure defined by the user, they cannot be reordered at the query level, however you can order the collection they produce.

MyModel::get()->orderBy('name');

Or alternatively consider using \October\Rain\Database\Traits\SimpleTree combined with \October\Rain\Database\Traits\Sortable.

[tiipiik]

@jan-vince @daftspunk Yes, that's it !
I just tested by removing the NestedTree trait and it works, many thanks guys !