October: Back-end Preferences - Locale

[marcoelho97]

Expected behavior

Well, in my opinion, the locale should have "Portuguese ( Portugal )"

Actual behavior

It has "Portuguese ( Brazil )

October build

I am using latest october build, 346

[nacr]

+1

[morsaPT]

+1

[nacr]

oh @jareis deixa-te de coisas é logo com os dois! qual é a tua, estas armado em esquisito! :dancer:

[daftspunk]

PR please

[nacr]

@daftspunk how much code exactly are we talking about here?

[daftspunk]

Portuguese ( Brazil ) and Portuguese ( Portugal ), identical language?

If there is no difference, simply call it Portuguese and we rename pt-br to pt.

Ok, so there looks like a difference. A suggestion would be to create pt-pt and include the strings from pt-br, then it can allow overrides for any differences.

[daftspunk]

Eg, this file: https://github.com/octobercms/october/blob/master/modules/system/lang/pt-br/lang.php

Pretend it is pt-pt/lang.php:

<?php

$lang = include __DIR__ . '/../pt-br/lang.php';
$lang['app']['name'] = 'Wakka wakka CMS';
return $lang;

See that we can still override the app.name key to something else, but use the remaining keys as a basis and prevent duplication for language that is the same between pt-br and pt-pt.

[LukeTowers]

Closing as it has been over a month since any activity on this occurred.