Oceananigans.jl: `scalar getindex is disallowed` with `topology = (Periodic, Bounded, Bounded)` using Oceananigans v0.34.1

Created on 22 Aug 2020  路  2Comments  路  Source: CliMA/Oceananigans.jl

Reported by @sandreza

Must have missed this (or tests didn't cover this case) in PR https://github.com/CliMA/Oceananigans.jl/pull/851

Screen Shot 2020-08-21 at 5 45 54 PM

GPU 馃懢 bug 馃悶
Source
picture ali-ramadhan

All 2 comments

Code is here:

https://github.com/CliMA/Oceananigans.jl/blob/424051cc05f1da09a7531af17c875c6abc0cb586/src/Solvers/channel_pressure_solver.jl#L121-L159

The issue is a call to view on line 138.

glwagner picture glwagner on 23 Aug 2020
👍1

Not sure why tests did not catch this in #851, but running tests on Tartarus is catching it now 馃し

Fixing and will open a PR.

ali-ramadhan picture ali-ramadhan on 27 Aug 2020
👀1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

francispoulin picture francispoulin  路  6Comments
truedichotomy picture truedichotomy  路  6Comments
freemin7 picture freemin7  路  5Comments
ali-ramadhan picture ali-ramadhan  路  7Comments
truedichotomy picture truedichotomy  路  8Comments