Objectmapper: After updating to Xcode 9.3 and Swift 4.1 Float is not able to map the values

Created on 31 Mar 2018 · 20Comments · Source: tristanhimmelman/ObjectMapper

I just updated to Xcode 9.3 and Swift 4.1 and Float is not able to map the values, but when I changed Float to CGFloat it is working fine.

It is giving lots of compilation warnings also. PFA attached screenshot of warnings.

screen shot 2018-03-31 at 12 53 09 pm

Source

krishnameena

👍13

Most helpful comment

I have the same problem.
The workaround that had less impact for me was to use a Custom Transform:

class CustomFloatTransform: TransformType {
    public typealias Object = Float
    public typealias JSON = NSNumber

    func transformFromJSON(_ value: Any?) -> Float? {
        if let number = value as? NSNumber {
            return number.floatValue
        }

        if let numberString = value as? String {
            return Float(numberString)
        }

        return nil
    }

    func transformToJSON(_ value: Float?) -> NSNumber? {
        if let float = value {
            return NSNumber(value: float)
        }
        return nil
    }
}

EduardoViegas on 7 Apr 2018

👍18

All 20 comments

As I see there was a discussion at swift.org about redeclaration warnings. And as I understood they were going to ask ObjectMapper's maintainers to fix this issue.

About Float it seems that for some reason NSNumber cannot be casted to Float. I got such error "Unable to bridge NSNumber to Float" and at this point I don't know what to do with it.

Sol88 on 2 Apr 2018

I got same issue on Swift 4.1 + Xcode 9.3. My workaround atm is to update our transformer to cast the object to NSNumber and get the .floatValue. There will be rounding issue, but it's not a problem at least for my project.

marioyohanes on 3 Apr 2018

👍5

Does anyone have solution?

AmirDaliri on 3 Apr 2018

We're worried about these warnings: so far everything looks like its working, but since we use it to transfer data to a backend we do not manage, it is very hard for us to confirm everything still works as it used to. Any idea when the warnings will be fixed?

mylemans on 3 Apr 2018

I am facing the same issue.
so I installed 9.2 with swift 4.0. Now it is working charmingly.
We have to use 9.2 and swift 4.0 until It is fixed. I didn't try Xcode 9.3 + Swift 4.0.

sandeepo2o on 3 Apr 2018

We are seeing the same warnings, Xcode 9.3 + Swift 4.0.

ecomGit on 4 Apr 2018

Same problems here

pmusolino on 5 Apr 2018

@sandeepo2o the problem is you need Xcode 9.3 with iOS 11.3 and many of us updated to iOS 11.3

quetool on 6 Apr 2018

I have similar issue here https://github.com/Hearst-DD/ObjectMapper/issues/955

quetool on 6 Apr 2018

I have the same problem.
The workaround that had less impact for me was to use a Custom Transform:

class CustomFloatTransform: TransformType {
    public typealias Object = Float
    public typealias JSON = NSNumber

    func transformFromJSON(_ value: Any?) -> Float? {
        if let number = value as? NSNumber {
            return number.floatValue
        }

        if let numberString = value as? String {
            return Float(numberString)
        }

        return nil
    }

    func transformToJSON(_ value: Float?) -> NSNumber? {
        if let float = value {
            return NSNumber(value: float)
        }
        return nil
    }
}

EduardoViegas on 7 Apr 2018

👍18

I've got the same issue on my projet.
@EduardoViegas's workaround works well until the bug is fixed.