Objectmapper: Swift 3 - Float mapping issue

[Sianay]

Since swift 3, ObjectMapper seems to not map float type correctly anymore

For example I have this dictionnary :
let dict: [String:Any] = ["manager":1, "self_assessment":0, "average":0, "total_answers":1]

and this object :

class AnswerOverview: Object, Mappable {
    dynamic var manager: Float = 0
    dynamic var selfAssessment: Float = 0
    dynamic var average: Float = 0
    dynamic var totalAnswers: Int = 0
}

when i tried to map it :
let answerOverview = Mapper<AnswerOverview>().map(JSON: dict)

my float values are still empty ( all equal to 0)

I have unit test for this and it was passing before with swift 2.2

[tristanhimmelman]

Hi @Sianay, We have unit tests for float in ObjectMapper and they are passing as in Swift 3.0

I'm not sure what the problem is in your case? What do you mean by the float values are empty? They are mapped to 0?

[Sianay]

Yes they are mapped to 0 instead of 1 in the case of the manager var

[Sianay]

I think in your unit test you assume that they are passed as float to float and this is working.
However in my dict these numbers are of the type Any and i want them to become Float

if I write my dict this way :
let dict: [String:Any] = ["manager":1 as Float , "self_assessment":0 as Float, "average":0 as Float, "total_answers":1]

then the values will be map correctly (manager = 1 ) but I can't force the type when i parse from real json

[tristanhimmelman]

{"float" : 0}

I am able to map the above to a var of type Float.

Maybe you can post your class so that I can have a better idea what is going on?

[Sianay]

here a screenshot of unit test :

my class

class AnswerOverview: Object, Mappable {

    dynamic var question: Question?

    dynamic var manager: Float = 0
    dynamic var selfAssessment: Float = 0
    dynamic var average: Float = 0

    dynamic var totalAnswers: Int = 0
    dynamic var totalComments: Int = 0

    dynamic var hiddenStrength: Bool = false
    dynamic var blindSpot: Bool = false

    var answerPreviews: List<AnswerPreview> = List<AnswerPreview>()
     var scrolledPage = 0

    override static func ignoredProperties() -> [String] {
        return ["scrolledPage"]
    }

    required convenience init?(map: Map) {
        self.init()
    }

    func mapping(map: Map) {
        question <- map[Constants.JSONKey.question]
        manager <-  map[Constants.JSONKey.manager]
        selfAssessment <- map[Constants.JSONKey.selfAssessment]
        average <- map[Constants.JSONKey.average]
        totalAnswers <- map[Constants.JSONKey.totalAnswers]
        totalComments <- map[Constants.JSONKey.totalComments]
        hiddenStrength <- map[Constants.JSONKey.hiddenStrength]
        blindSpot <- map[Constants.JSONKey.blindSpot]
        answerPreviews <- (map[Constants.JSONKey.answerPreviews], RealmListTransform<AnswerPreview>())
    }

[Sianay]

Ok so if it can help you this is working with JSONString but not with a dict

[tristanhimmelman]

I was able to reproduce your issue. It seems that Swift 3 is not able cast a value of type Any to a Float.

let anyVal: Any = 11
let float = anyVal as? Float // This results in nil

I'm not sure how I will address this yet, but thanks for bringing it up.

[CaptainMack]

I might be having same problem using Double and Int. For some reason, mapping JSON to these types fail - String type maps correctly.

[hardeep]

I'm having this issue on swift 2.2 (ObjectMapper "1.4.0") as well.

My current solution is to use map["someKey"].currentValue?.floatValue

User error on my behalf. The API I was using was enclosing the float in quotes. I'll leave this comment in case anyone is running into the same issue on 2.2.

[hardeep]

@tristanhimmelman I wonder if this has anything to do with your issue. http://stackoverflow.com/questions/32554357/is-float-double-int-an-anyobject

[tristanhimmelman]

Oddly I am no longer able to reproduce this issue on v2.1.0. See my test below:

    func testMappingFloatFromJSON(){
        let value: Float = 11
        let JSON: [String: Any] = ["float": 11 as Float, "floatOpt": value, "floatImp" : value]

        let mappedObject = BasicTypes(JSON: JSON)

        XCTAssertNotNil(mappedObject)
        XCTAssertEqual(mappedObject?.float, value)
        XCTAssertEqual(mappedObject?.floatOptional, value)
        XCTAssertEqual(mappedObject?.floatImplicityUnwrapped, value)
    }

[devxoul]

@tristanhimmelman, this problem occurs with enum.

Try adding this line to testNestedKeys() function in NestedKeyTests.swift.

XCTAssertEqual(value.floatEnum, FloatEnum.b) // this will fail because `value.floatEnum` is `nil`.

[jsgoupil]

I have found the same problem and opened the bug right here:

https://github.com/Hearst-DD/ObjectMapper/issues/636

[sallyahmed]

• 1 here !

[j2damax]

Use CGFloat instead of Float

[FerdiKT]

I have same problem on İOS 11 (same version of app with no problem on ios 10). I used Double instead of Float and it's working now.

[conqueror]

If I have a Double? and I receive a value without decimals in the JSON such as 4, ObjectMapper does not map it.
In case I receive a value with decimals like 4.00 then ObjectMapper maps it properly.

[oleghnidets]

Have the same issue as @conqueror. To solve the issue I have to use NSNumber but it is not what I expect from the library (still cool lib 👍🏻).
@tristanhimmelman Any updates on that?

[SebastianCrow]

Personally, I'm using a custom transformer like that to have it mapped correctly:

TransformOf<Float, NSNumber>(
    fromJSON: { (value: NSNumber?) -> Float? in
        return value?.floatValue
    },
    toJSON: {
        if let float = $0 {
            return float as NSNumber
        }
        return nil
    }
)

However, it would be nice if float mapping would work out of the box

[tisohjung]

I have two phones. iPhone6s running on 11.3, iPhone5 running on 10.3
iPhone6s parses when using CGFloat, but not using Float
iPhone5 parses when using Float, but not using CGFloat
so just changing it to CGFloat means older versions of iOS will not be properly supported

[Adrift001]

same problem too.

[Adrift001]

959 solved