Objection.js: virtual attributes are not serialized to JSON when returned in koa middleware

[capaj]

we had this working correctly in 1.6.3, but after upgrading to 1.6.6 we lost all virtual attributes in the JSON we get back from the API

[koskimas]

Let's try this again, this time with some information. There are tests for virtual attributes. They all pass.

[capaj]

I have this model:

and calling toJSON produces same result in both 1.6.3 and 1.6.6:

logs:

but when I return this in koa middleware, the virtual attributes are not included-this is the payload I get for 1.6.3

this is the payload I get for 1.6.6

no other dependency has changed in my stack.

[koskimas]

If toJSON() works as expected, how could this be objection's fault? Unless koa somehow passes an object with { virtuals: [] } or { virtuals: false } to toJSON. I'm afraid I'll need a reproduction for this. There's a test case for nested virtuals too and it works.

[koskimas]

If not a reproduction, at least I'll need something more to work with so that I can reproduce this.

[capaj]

I'll close this for now and reopen only if I can add a unit test.

[koskimas]

Found the bug. Sorry about this. I'm releasing 1.6.7 right now.