Objection.js: upsertGraph with relation over composite key does not work properly anymore

[falkenhawk]

It looks like a regression sneaked in in v1.6.4. When upserting a graph with a model + relation with composite key, the values for foreign columns are not carried over from the base model. Instead they are NULL, which breaks and throws an error (of course only if columns are NOT NULL, otherwise the records would be inserted, but probably not related).

It worked until v1.6.3.

Please find the reproduction template attached:
reproduction-template.zip

[koskimas]

Jesus christ this fucking upsertGraph.. I'll remove the whole fucking thing one day. I'll try to find time to fix this within the next month.

[falkenhawk]

@koskimas nooo please don't remove it, I know you are kind of regretting adding this because of all the headaches it sometimes causes, but it's really a brilliant feature :) Thank you, I will stick with 1.6.3 for now

[koskimas]

Yeah, I think we are stuck with it :smile: It's just that no matter how many tests I write, there's always some way to use it that I haven't considered and it breaks

[koskimas]

Thanks for the reproduction by the way. Sorry for lashing out like this. Having a bad day :grimacing:

[koskimas]

The fix was really easy this time. A new version coming up.

[flipace]

@koskimas i can't thank you enough. can we buy you a beer?

[koskimas]

Thanks, but I'm also the person who broke it :smile:

[koskimas]

1.6.6 is now released