Objection.js: Add new method 'mergeAllowEager' to 'QueryBuilder'

Created on 5 Oct 2017  路  4Comments  路  Source: Vincit/objection.js

Add a QueryBuilder.mergeAllowEager method, which behaves similar to how QueryBuilder.mergeEager does.

enhancement good first issue help wanted
Source
picture zuck

All 4 comments

Good idea! I'll do that.

koskimas picture koskimas on 6 Oct 2017
🎉1

Actually, here's a good first contribution if someone wants to create pull request.

Here's some pointers:

  1. See what mergeEager does. mergeAllowEager is pretty much the same.
  2. The method would need to be tested. See tests/unit/queryBuilder/QueryBuilder.js line 1165 for allowEager tests.
  3. The method must be documented. See the doc/includes/API.md file.
koskimas picture koskimas on 10 Oct 2017

I've been meaning to tackle this one...will try and get to it this weekend...

newhouse picture newhouse on 20 Oct 2017

Added by @newhouse in https://github.com/Vincit/objection.js/commit/f7606bf665da599eae03ecbed3cc4b7d43983953

koskimas picture koskimas on 21 Oct 2017
🎉1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

chen7david picture chen7david  路  3Comments
officer-rosmarino picture officer-rosmarino  路  4Comments
mycahjay-nms picture mycahjay-nms  路  4Comments
apronin83 picture apronin83  路  3Comments
ghost picture ghost  路  3Comments