Oauth2-proxy: Exclude go version from asset link

Created on 25 Jun 2020  路  4Comments  路  Source: oauth2-proxy/oauth2-proxy

Expected Behavior

Other projects just include the version of the dependency itself, so that it easily be bumped

Current Behavior

Oauth2 proxy includes the go version, which as I user of oauth2-proxy, I don't care about.

Possible Solution

Exclude go version from release asset

E.g. instead of

- https://github.com/oauth2-proxy/oauth2-proxy/releases/download/v5.1.1/oauth2_proxy-v5.1.1.linux-amd64.go1.14.2.tar.gz
+ https://github.com/oauth2-proxy/oauth2-proxy/releases/download/v5.1.1/oauth2_proxy-v5.1.1.linux-amd64.tar.gz

Context

E.g. when using ansible to deploy, you might have the version of oauth2-proxy in your group_vars, like this

oauth2_proxy_version: "5.1.1"

which ansible uses then to complete the jinja2 template

https://github.com/oauth2-proxy/oauth2-proxy/releases/download/v{{ oauth2_proxy_version }}/oauth2_proxy-v{{ oauth2_proxy_version }}.linux-amd64.go1.14.2.tar.gz  # the go version makes this not work

@dlouzan @fh1ch

question

Most helpful comment

@max-wittig fixed in #733 if you want to take a look.

All 4 comments

I don't really know why we do this tbh, I know it was done before we adopted the repository from Bitly and I guess we just carried it on.

I don't really see an issue in changing it, except from it could be considered a breaking change.

@syscll @gargath I know you both have had opinions on this stuff before, any thoughts?

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.

This should not be closed.

@max-wittig fixed in #733 if you want to take a look.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

martinssipenko picture martinssipenko  路  4Comments

dennisbrouwer91 picture dennisbrouwer91  路  7Comments

christidis picture christidis  路  7Comments

cccs-cat001 picture cccs-cat001  路  6Comments

jtnord picture jtnord  路  5Comments