Oauth2-proxy: Support for GitLab groups

Created on 30 Jul 2019  路  6Comments  路  Source: oauth2-proxy/oauth2-proxy

Opening issue for supporting GitLab groups, so that if using the gitlab provider, it's possible to limit authentication to only members of your group / organization.

Expected Behavior

The GitLab provider should have something similar to the GitHub provider like so:

  -github-org string
        restrict logins to members of this organisation
  -github-team string
        restrict logins to members of this team

Current Behavior

Currently, the GitLab provider only supports a very basic OAuth2 integration, which is that everyone with an account in that GitLab instance (whether it's self-hosted, or their SaaS offering) can authenticate with some proxied backend.

Possible Solution

This should be possible since Grafana has support for groups with their GitLab OAuth integration => https://grafana.com/docs/auth/gitlab/

Steps to Reproduce (for bugs)

N/A

Context

N/A

Your Environment

  • Version used: v3.2.0
enhancement good first issue help wanted

Most helpful comment

Closing since https://github.com/pusher/oauth2_proxy/pull/231 was merged! Thanks to @Overv !

All 6 comments

There was some work done around this but it never got merged, perhaps someone could pick it up again? https://github.com/pusher/oauth2_proxy/pull/137

I've been working on a similar PR, but I'd like to implement it differently than #137 so that it only requires the openid scope and not the whole api.

@JoelSpeed thanks for the suggestion.

@Overv I was going to take the code JoelSpeed had suggested, and modify it to get it merged. If you don't have time I can work on it, but I don't know how much progress you've made.

@sc250024 I'm pretty far along and will be submitting a PR early next week.

@Overv Oh cool! Honestly, I spun up this issue to remind myself to do it soon, but if you've already done it, that's awesome. Thank you so much!

Closing since https://github.com/pusher/oauth2_proxy/pull/231 was merged! Thanks to @Overv !

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dennisbrouwer91 picture dennisbrouwer91  路  7Comments

lentzi90 picture lentzi90  路  5Comments

apeschel picture apeschel  路  5Comments

desaintmartin picture desaintmartin  路  5Comments

fmotrifork picture fmotrifork  路  3Comments