Nx: [Angular + Nest] ESLint not properly set with preset with --linter=eslint

Created on 16 Dec 2020  ·  5Comments  ·  Source: nrwl/nx

Current Behavior

As described in #4272, the present for --linter=eslint was not used for the preset angular template. This has been fixed by @vsavkin in nx 11.0.8. Unfortunately, this has not been fixed for the angular & nest preset.

Steps to Reproduce




  • npx create-nx-workspace@latest
  • select the angular & nest preset
  • wait
  • check the created angular project

Environment


Nx 11.0.8 (latest)

core bug

Most helpful comment

All 5 comments

Have been just about to create the same issue, thanks @johannesschobel 🙇
The same applies to the angular preset as well 😢

@AmirAlOmari , no, the angular preset has been fixed in 11.0.8.. Please see #4272 for more details

@johannesschobel did you try it? I just tested with both 11.0.8 and latest tags. There are some logs

Also reported the same behaviour in nx slack #support, also with 11.0.8
https://nrwlcommunity.slack.com/archives/CMFKWPU6Q/p1608128862092800

❯ npx [email protected]
npx: installed 192 in 9.921s
? Workspace name (e.g., org name)     ipallower
? What to create in the new workspace angular           [a workspace with a single Angular application]
? Application name                    admin
? Default stylesheet format           SASS(.scss)  [ http://sass-lang.com   ]
? Default linter                      ESLint [ Modern linting tool ]
? Use Nx Cloud? (It's free and doesn't require registration.) Yes [Faster builds, run details, Github integra
tion. Learn more at https://nx.app]
Creating a sandbox with Nx...
added 192 packages from 155 contributors and audited 193 packages in 6.188s

23 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

new ipallower --no-interactive --preset=angular --appName=admin --style=scss --linter=eslint --nxCloud --collection=@nrwl/workspace

What actually works fine: in angular.json there are default rules for ng schematics. Those now define eslint as default linter, so nx g @nrwl/angular:app generates app with the right linter 🚀

Btw, having a look at the changes in 11.0.8 doesn't seem to me like it could be fixed at first glance

Was this page helpful?
0 / 5 - 0 ratings

Related issues

MichaelWarneke picture MichaelWarneke  ·  3Comments

zpydee picture zpydee  ·  3Comments

ZempTime picture ZempTime  ·  3Comments

danieldanielecki picture danieldanielecki  ·  3Comments

sukei picture sukei  ·  3Comments