Nx: Remove TSLint (deprecated)

Created on 19 May 2020  ·  7Comments  ·  Source: nrwl/nx

Prerequisites

Please answer the following questions for yourself before submitting an issue.
YOU MAY DELETE THE PREREQUISITES SECTION.

  • [X] I am running the latest version
  • [X] I checked the documentation (nx.dev) and found no answer
  • [X] I checked to make sure that this issue has not already been filed
  • [X] I'm reporting the issue to the correct repository (not related to React, Angular or any dependency)

Expected Behavior

As described in their post about it, tslint is now deprecated - instead @typescript-eslint/eslint-plugin and @typescript-eslint/parser should be used with eslint. This seems to already be happening in the main .eslintrc, so tslint should no longer be needed

Current Behavior

Tslint is included when generating a workspace, but shouldn't be needed since @typescript-eslint/parser is included and setup within .eslintrc.

Failure Information (for bugs)

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Run npx create-nx-workspace@latest repro-workspace
  2. See that tslint is within package file
more info needed angular feature

Most helpful comment

Hi, interesting thread but you got the wrong Alex 🅰️

All 7 comments

It's blocked by the angular CLI. There are some usecases where ESLint is a regression, for example this: https://github.com/typescript-eslint/typescript-eslint/issues/1856

Oh, great to know, thanks for the explanation @alexeagle. Would it be possible to only include that when generating an angular project? I was generating a react project, so wasn't aware

Hi, interesting thread but you got the wrong Alex 🅰️

@AlexAegis ^

would be nice to be able to specify default linter for the whole workspace.

Also, I manually migrate our workspace to ESLint, but when generating a new library, still generates with tslint. Is there any way to generate with eslint atm or we need to manually change the angular.json for that?

Closing as a duplicate of #1699

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vimalraj-a picture vimalraj-a  ·  3Comments

dereklin picture dereklin  ·  3Comments

IonFoXx picture IonFoXx  ·  3Comments

Koslun picture Koslun  ·  3Comments

MichaelWarneke picture MichaelWarneke  ·  3Comments